Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNS1-3281: Decode TVL state from stable memory #5443

Merged
merged 3 commits into from
Oct 8, 2024
Merged

NNS1-3281: Decode TVL state from stable memory #5443

merged 3 commits into from
Oct 8, 2024

Conversation

dskloetd
Copy link
Contributor

@dskloetd dskloetd commented Sep 12, 2024

Motivation

This is the follow-up to #5431
In that PR we stored the TVL state to stable memory but we couldn't yet restore the TVL state from stable memory because we didn't have a release that made sure there was TVL state to be restored from stable memory.

After the most recent upgrade we now do so we can complete the TODOs left in that PR.

Changes

  1. Load TVL state from stable memory.
  2. Decode loaded TVL state into canister state.

Tests

  1. Remove test that checks TVL state is not decoded.
  2. Update test to make sure that TVL state is decoded.

Todos

  • Add entry to changelog (if necessary).
    covered

@dskloetd dskloetd changed the title TVL NNS1-3281: Restore TVL state from stable memory Oct 7, 2024
@dskloetd dskloetd changed the title NNS1-3281: Restore TVL state from stable memory NNS1-3281: Decode TVL state from stable memory Oct 7, 2024
@dskloetd dskloetd marked this pull request as ready for review October 7, 2024 14:12
@dskloetd dskloetd requested a review from a team as a code owner October 7, 2024 14:12
@dskloetd dskloetd added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 7a19713 Oct 8, 2024
30 checks passed
@dskloetd dskloetd deleted the kloet/tvl branch October 8, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants