build: bump test dependencies #5482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
# Motivation Many dev dependencies are becoming a bit outdated therefore I suggest to bump most of those to stay up-to-date. This PR bumps dev dependencies including Sveltekit but excluded: - Typescript and eslint for compatibility reason (eslint v8 vs v9) - Prettier -> #5481 - Vitest and related libs -> #5482 - Playwright -> #5483 - Sass as it throws warnings and/or require update the styles (as we recently did in [gix-cmp](dfinity/gix-components#471)) # Changes - Update Svelte and SvelteKit related libraries - Update vite - Update few minor dev dependencies (dotenv etc.) --------- Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
# Conflicts: # CHANGELOG-Nns-Dapp-unreleased.md
|
@dskloetd big PR but, there is also a big gap between vitest Thanks a ton @mstrasinskis for the help! |
dskloetd
reviewed
Oct 15, 2024
frontend/src/tests/lib/services/worker-transactions.services.spec.ts
Outdated
Show resolved
Hide resolved
frontend/src/tests/lib/services/worker-transactions.services.spec.ts
Outdated
Show resolved
Hide resolved
This reverts commit 319e0d9.
This reverts commit 880199b.
This reverts commit 612d62f.
This reverts commit 936bec6.
… certified" This reverts commit 231b0d4.
# Conflicts: # CHANGELOG-Nns-Dapp-unreleased.md # frontend/src/tests/lib/services/actionable-sns-proposals.services.spec.ts # frontend/src/tests/lib/services/public/proposals.services.spec.ts
Because of this message: You have specified a baseUrl and/or paths in your tsconfig.json which interferes with SvelteKit's auto-generated tsconfig.json. Remove it to avoid problems with intellisense. For path aliases, use `kit.alias` instead: https://kit.svelte.dev/docs/configuration#alias MISSING DEPENDENCY Cannot find dependency 'jsdom' ? Do you want to install jsdom? › (y/N)
…o build/bump-test-dps
This reverts commit 49bc925.
This reverts commit 767da63.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
# Motivation After upgrading the test dependencies (#5482), the Wallet test doesn’t pass. This could be an issue specific to [the test](https://github.com/dfinity/nns-dapp/pull/5482/files#r1806490235), but using get instead of $ in areas that don’t rely on dynamic updates might be a good idea. # Changes - Replace $ with get. # Tests - Pass # Todos - [ ] Add entry to changelog (if necessary). not necessary
This reverts commit 3288332.
dskloetd
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Upgrade the test dependencies.
Changes
vitest.configfor breaking changessvelteTestingpluginuseAtomicsconfig