Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove separate uploading of assets from deploy-to-app.yaml #5558

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

dskloetd
Copy link
Contributor

@dskloetd dskloetd commented Oct 1, 2024

Motivation

The nns-dapp wasm is bigger than 2 MB. When the deploy-to-app workflow was created, this meant that the wasm couldn't be installed to an application subnet.
The "real" nns-dapp isn't affected by this because the NNS subnet allows larger messages.
To work around this, a mechanism was implemented to build and install a wasm without assets and upload the assets separately.
This is no longer necessary because the IC now supports uploading the wasm in chunks and then installing the wasm from chunks. dfx also supports this transparently.
So we can simply call dfx to install the large wasm and everything happens correctly behind the scenes.

Changes

  1. Remove the calls to split the assets.
  2. Install the standard wasm instead of the noassets wasm.
  3. Remove the calls to upload the assets.

Tests

https://beta.nns.ic0.app/ is working again because it was installed and upgraded this way:

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review October 1, 2024 13:05
@dskloetd dskloetd requested a review from a team as a code owner October 1, 2024 13:05
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dskloetd dskloetd added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 4d75d23 Oct 1, 2024
31 checks passed
@dskloetd dskloetd deleted the kloet/beta-deploy branch October 1, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants