Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): auto-update package-lock file #2249

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat(ci): auto-update package-lock file #2249

wants to merge 3 commits into from

Conversation

AntonioVentilii-DFINITY
Copy link
Contributor

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY commented Sep 5, 2024 •
edited
Loading

Motivation

it would be useful to have a check/action that auto-updates the package-lock.json file if there is a need for it if package.json has changed.

@peterpeterparker
Copy link
Member

I would say not until we got tests. There might be often updates and each of those will need tests.

@AntonioVentilii-DFINITY
Copy link
Contributor Author

@peterpeterparker then I will leave as draft for now

@peterpeterparker
Copy link
Member

If you agree of course - i.e. if my comment makes sense?

@AntonioVentilii-DFINITY
Copy link
Contributor Author

yes yes, agreed, makes sense. I will just leave it here as draft otherwise I end up forgetting it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonioVentilii-DFINITY @peterpeterparker