-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): BTC transactions [GIX-2795] #2547
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenysKarmazynDFINITY
changed the title
feat(frontend): implement service for communicating with Blockchain A…
feat(frontend): BTC transactions
Sep 26, 2024
DenysKarmazynDFINITY
force-pushed
the
feat(frontend)/btc-transactions
branch
from
September 27, 2024 08:31
16d3130
to
3841dc1
Compare
DenysKarmazynDFINITY
changed the title
feat(frontend): BTC transactions
feat(frontend): BTC transactions [GIX-2795]
Sep 27, 2024
DenysKarmazynDFINITY
force-pushed
the
feat(frontend)/btc-transactions
branch
2 times, most recently
from
September 27, 2024 14:11
b7ea05d
to
7ae3280
Compare
DenysKarmazynDFINITY
force-pushed
the
feat(frontend)/btc-transactions
branch
from
October 1, 2024 14:34
7ae9a27
to
88ae0df
Compare
…PI (#2507) # Motivation The goal is to implement service for communicating with Blockchain API. Initially, it will be used for fetching uncertified BTC transactions.
# Motivation Remove unnecessary slash from `btcAddressData`.
# Motivation The goal is to extend BTC networks with already defined explorer URLs. It will be used in the BTC transaction detail modal.
…-2795] (#2549) # Motivation Removing the temporary type for BTC wallet since we are going to re-use `PostMessageDataResponseWallet`.
# Motivation BTC transaction modal stores.
# Motivation Extend `blockchain.rest` with the `btcLatestBlock` function. It will be used for calculating the number of confirmations for a BTC transaction.
# Motivation Add BTC transaction stores. It will be later extended with additional methods, similar to other related stores (e.g. `cleanUp`).
# Motivation A parser for BTC transactions. It will later extended with additional field: "confirmations".
# Motivation The goal is to update the BTC wallet worker to fetch transactions. Similar to other store, we only load a BTC address if it hasn't been already fetched by FE.
DenysKarmazynDFINITY
force-pushed
the
feat(frontend)/btc-transactions
branch
from
October 1, 2024 14:53
88ae0df
to
0c651d9
Compare
DenysKarmazynDFINITY
force-pushed
the
feat(frontend)/btc-transactions
branch
from
October 1, 2024 14:58
0c651d9
to
6c1e5b0
Compare
peterpeterparker
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the base branch for BTC transactions feature.