Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http(s) proxy support #78

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wangshijun
Copy link

My users donot have direct network access to api.ai, but the proxy feature is missing from current version, so I implemented proxy feature with the awesome proxy-agent lib.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@wangshijun
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@rjivan
Copy link

rjivan commented Aug 26, 2017

I'm looking for the same feature. Is there anything that's preventing this from being merged?

@wangshijun
Copy link
Author

@rjivan you can just use my branch by yarn add wangshijun@apiai-nodejs-client

@sctse999
Copy link

Hello, can anyone pls merge this PR? this is quite needed

@lmonzon
Copy link

lmonzon commented Sep 20, 2017

@wangshijun no work yarn add wangshijun@apiai-nodejs-client

@sctse999
Copy link

@sstepashka could you pls take a look at this PR and merge if possible? Really want to work with the official library instead of a forked one.....

Copy link

@supradeepk supradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add this

@ChellaTheCoder
Copy link

Is it merged or any alternative for proxy support ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants