proof of concept for mul_tr #1387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a (presumed) typo in documentation in matrix_view.rs. Previously it says fixed_view and fixed_slice returns a matrix with `(R::dim(), CView::dim())` consecutive components. I just changed R to RView, because presumably this is a typo.
Fixed a (presumed) typo in documentation in matrix_view.rs. Previously it says fixed_view and fixed_slice returns a matrix with `(RView, CView)` consecutive components. As per-input, and after re-reading the documentation and source code. Seems like RView and CView should be used instead of RView::dim() and CViem::dim().
Fixed spacing in documentation.
added mut_tr and the corresponding hidden yy_mul_to_uninit function.
added a test for mul_tr to verify that we get m.mul_tr(v) is m*v.transpose(). also changed the name of the previous test for tr_mul to clarify which side of the multiplication is being transposed.
Fixed a typo.. oops.
Fixed a typo in documentation in matrix_view.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw issue #1254. Attempted to implement it following the implementation for tr_mul. I'm not quire sure why the original hidden function was called xx_mul_to_unit (specifically the
xxpart), but I made a corresponding function yy_mul_to_uninit.Opening this pull request mainly to gather feedback, and if all is good I should be able to write other variations of the functions in ops.rs such as mul_ad, mul_tr_to, etc.
I also also wanted to add a test similar to
tr_mul_is_transpose_then_mulwas for tr_mul, except for the new mul_tr function. I'm not used to writing tests, and especially not the proptest library. I was able to write a test, but I had to resort to physically transposing a column vector for the test.Not really a programmer by trade, new to github. Feedback welcomed.