Use assertions

discoveryjs · Oct 30, 2023 · a923c7c · a923c7c
1 parent 72a41c0
commit a923c7c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/extensions/inspector.js b/src/extensions/inspector.js
@@ -278,7 +278,7 @@ export default (host) => {
                                         data => data.value.view && data.value.view.skipped ? 'skipped' : false
                                     ],
                                     content: [
-                                        'text:value | viewRoot.name or view.config.view | $ + "" = $ ? $ : "ƒn"' // FIXME: `$ + "" = $` is a hack to check value is a string
+                                        'text:value | viewRoot.name or view.config.view | is string ?: "ƒn"'
                                         // {
                                         //     view: 'list',
                                         //     when: false, // postponed for future releases

diff --git a/src/extensions/inspector/props-config.js b/src/extensions/inspector/props-config.js
@@ -12,7 +12,7 @@ export const propsConfigView = {
         {
             view: 'block',
             className: 'content-section render',
-            when: 'config | view + "" != view',
+            when: 'config.view is not string',
             content: 'source:{ content: config.view + "", syntax: "js" }'
         },
         {

diff --git a/src/extensions/inspector/view-tree.js b/src/extensions/inspector/view-tree.js
@@ -84,7 +84,7 @@ export function viewTree(el, { selectTreeViewLeaf, detailsSidebarLeafExpanded })
                                 data => data.view?.skipped ? 'skipped' : false,
                                 'selected'
                             ],
-                            content: 'text:view.config.view or "#root" | $ + "" = $ ? $ : "ƒn"', // FIXME: `$ + "" = $` is a hack to check value is a string
+                            content: 'text:view.config.view or "#root" | is string ?: "ƒn"',
                             postRender(el_) {
                                 requestAnimationFrame(() => {
                                     el.querySelector('.sidebar').scrollTop = viewTreeScrollTopBeforeSelect;
@@ -100,7 +100,7 @@ export function viewTree(el, { selectTreeViewLeaf, detailsSidebarLeafExpanded })
                         {
                             view: 'link',
                             className: data => data.view?.skipped ? 'skipped' : false,
-                            data: '{ text: view.config.view or "#root" | $ + "" = $ ? $ : "ƒn", href: false, view, self: $ }', // FIXME: `$ + "" = $` is a hack to check value is a string
+                            data: '{ text: view.config.view or "#root" | is string ?: "ƒn", href: false, view, self: $ }',
                             onClick(_, data) {
                                 viewTreeScrollTopBeforeSelect = el.querySelector('.sidebar')?.scrollTop || 0;
                                 selectTreeViewLeaf(data.self);