Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical updates to articles in the DNS section - final articles #1253

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Critical updates to articles in the DNS section - final articles #1253

wants to merge 22 commits into from

Conversation

itsalyse
Copy link
Contributor

@itsalyse itsalyse self-assigned this Sep 18, 2024
@itsalyse itsalyse changed the title Critical updates dns articles 3 Final updates to the Critical articles in the DNS section Sep 18, 2024
@itsalyse itsalyse changed the title Final updates to the Critical articles in the DNS section Critical updates to articles in the DNS section - final articles Sep 18, 2024
itsalyse
itsalyse commented Sep 19, 2024
View reviewed changes
content/articles/dnssec.md Outdated Show resolved Hide resolved
itsalyse
itsalyse commented Sep 19, 2024
View reviewed changes
content/articles/dnssec.md Outdated Show resolved Hide resolved
itsalyse
itsalyse commented Oct 10, 2024
View reviewed changes
content/articles/dnssec.md Outdated Show resolved Hide resolved
itsalyse
itsalyse commented Oct 10, 2024
View reviewed changes
content/articles/dnssec.md Outdated Show resolved Hide resolved
@itsalyse itsalyse marked this pull request as ready for review October 10, 2024 19:22
@itsalyse itsalyse added the help wanted Extra attention is needed. label Oct 11, 2024
@itsalyse
Copy link
Contributor Author

@dperrymorrow the copy is finalized, and this is ready for screenshots

@weppos weppos added the documentation Updates on the documentation and support content. label Oct 16, 2024
@dperrymorrow
Copy link
Contributor

ok @itsalyse sorry for the delay, Ill try to get this done today

@dperrymorrow dperrymorrow removed the help wanted Extra attention is needed. label Oct 16, 2024
@dperrymorrow
Copy link
Contributor

@itsalyse screenshots have been added please check out the preview url and let me know if it is 👌🏼

@itsalyse
Copy link
Contributor Author

@dperrymorrow the dnssec article looks good, thanks! I added the record note screenshots in the comments so once those are up we should be good to merge

@dperrymorrow
Copy link
Contributor

Ok i have updated the screenshots provided for record notes. Let me know if this is ready to push out live

@itsalyse
Copy link
Contributor Author

@dperrymorrow the screenshots look good but the numbering is wonky again — is there a way I can update it that'll prevent that from happening when we add the screenshots?

@itsalyse itsalyse added the help wanted Extra attention is needed. label Oct 22, 2024
itsalyse
itsalyse commented Nov 14, 2024
View reviewed changes
content/articles/record-notes.md

![screenshot: dns badge navigation item](/files/dns-badge.png)

1. To add a note to an existing record, click the **Add Note** icon on the right side, and enter your note.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dperrymorrow can you fix the numbering here and on 36? it's not showing up correctly in the preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanoodle stephanoodle stephanoodle approved these changes

@Pemacaa Pemacaa Pemacaa approved these changes

@dperrymorrow dperrymorrow Awaiting requested review from dperrymorrow

Assignees

@itsalyse itsalyse

Labels
documentation Updates on the documentation and support content. help wanted Extra attention is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@itsalyse @dperrymorrow @Pemacaa @stephanoodle @weppos