Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list/tree: Hide Used column if no truthy value #5357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vvoland
Copy link
Collaborator

@vvoland vvoland commented Aug 19, 2024

Don't show the Used column in the image tree view when no image is actually used and the column would be empty.

- A picture of a cute animal (not mandatory but encouraged)

@vvoland vvoland added area/ux containerd-integration Issues and PRs related to containerd integration labels Aug 19, 2024
@vvoland vvoland added this to the 27.2.0 milestone Aug 19, 2024
@vvoland vvoland requested a review from a team August 19, 2024 10:28
@vvoland vvoland self-assigned this Aug 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 60.90%. Comparing base (0be9e2f) to head (54a4ab1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5357      +/-   ##
==========================================
- Coverage   60.92%   60.90%   -0.02%     
==========================================
  Files         304      304              
  Lines       21340    21345       +5     
==========================================
  Hits        13001    13001              
- Misses       7409     7414       +5     
  Partials      930      930              

@krissetto
Copy link
Contributor

I'm not totally sure about this from a UX perspective.. wouldn't it risk being a bit confusing for the users if sometimes they see the column and sometimes they don't?

@laurazard
Copy link
Member

I'm fine with it for now since this is behind an experimental flag, but we should review these questions before making it stable.

Don't show the `Used` column in the image tree view when no image is
actually used and the column would be empty.

Signed-off-by: Paweł Gronowski <[email protected]>
@vvoland vvoland marked this pull request as ready for review August 19, 2024 11:26
@thaJeztah thaJeztah modified the milestones: 27.2.0, 27.2.1, 28.0.0 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux containerd-integration Issues and PRs related to containerd integration status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants