-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add "rootless mode" to exceptions of "Privileged user requirement" #5359
Conversation
Thank you for contributing! It appears your commit message is missing a DCO sign-off, We require all commit messages to have a
There is no need to open a new pull request, but to fix this (and make CI pass), Unfortunately, it's not possible to do so through GitHub's web UI, so this needs You can find some instructions in the output of the DCO check (which can be found Steps to do so "roughly" come down to:
Sorry for the hassle (I wish GitHub would make this a bit easier to do), and let me know if you need help or more detailed instructions! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5359 +/- ##
=======================================
Coverage 59.78% 59.78%
=======================================
Files 345 345
Lines 23394 23394
=======================================
Hits 13985 13985
Misses 8438 8438
Partials 971 971 |
Signed-off-by: Javier Yong <[email protected]>
Hi @dvdksn, my sincere apologies! Thank you for the in-depth instructions, the sign-off should be reflected for the commit! |
Hi @laurazard @vvoland, I notice that this PR has a merge conflict. Would you prefer if I resolve the conflict and request for approval again? |
Hi @Javiery3889! Yes, we'd appreciate if you could resolve the conflict and then we can merge :) |
Signed-off-by: Javier Yong <[email protected]>
Modify source files for docs instead as mentioned in docker/docs#20637.