Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[27.x backport] docs: update docker login reference #5386 #5394

Merged
merged 2 commits into from
Sep 3, 2024
Merged

[27.x backport] docs: update docker login reference #5386 #5394

merged 2 commits into from
Sep 3, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Sep 3, 2024

@dvdksn
docs: update docker login reference
7a50cd0 
Signed-off-by: David Karlsson <[email protected]>
(cherry picked from commit 2f206ff)
Signed-off-by: David Karlsson <[email protected]>
@dvdksn
copynit: s/WEB BASED/WEB-BASED/
6274754 
Signed-off-by: David Karlsson <[email protected]>
(cherry picked from commit 81744d7)
Signed-off-by: David Karlsson <[email protected]>
@dvdksn dvdksn requested review from thaJeztah and a team as code owners September 3, 2024 10:23
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.99%. Comparing base (1a0b6a7) to head (6274754).
Report is 6 commits behind head on 27.x.

Additional details and impacted files 
@@           Coverage Diff           @@
##             27.x    #5394   +/-   ##
=======================================
  Coverage   60.99%   60.99%           
=======================================
  Files         304      304           
  Lines       21357    21357           
=======================================
  Hits        13026    13026           
  Misses       7402     7402           
  Partials      929      929

@thaJeztah thaJeztah added this to the 27.2.1 milestone Sep 3, 2024
@thaJeztah thaJeztah changed the title [27x backport] docs: update docker login reference #5386 [27.x backport] docs: update docker login reference #5386 Sep 3, 2024
thaJeztah
thaJeztah approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit c5d8467 into docker:27.x Sep 3, 2024
98 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

@dvdksn dvdksn

Labels
area/authentication kind/docs status/3-docs-review
Projects
None yet
Milestone
27.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@dvdksn @codecov-commenter @thaJeztah