Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not underline image name #5473

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Do not underline image name #5473

merged 1 commit into from
Sep 23, 2024

Conversation

rumpl
Copy link
Member

@rumpl rumpl commented Sep 23, 2024

- What I did

Removed the underline from the blue image names. Blue text with underline looks too much as a hyperlink I can click on

Before:
Screenshot 2024-09-23 at 15 30 29

After:
Screenshot 2024-09-23 at 15 36 06

- How I did it

...
- How to verify it

- Description for the changelog

- containerd image store:  do not underline names in `docker image ls --tree`.

- A picture of a cute animal (not mandatory but encouraged)

Blue text with underline looks too much as a hyperlink I can click on

Signed-off-by: Djordje Lukic <[email protected]>
@rumpl rumpl requested a review from vvoland September 23, 2024 13:38
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.74%. Comparing base (66977d4) to head (1704089).
Report is 47 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5473   +/-   ##
=======================================
  Coverage   59.74%   59.74%           
=======================================
  Files         345      345           
  Lines       23431    23431           
=======================================
  Hits        13999    13999           
  Misses       8458     8458           
  Partials      974      974           

laurazard

This comment was marked as duplicate.

Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like it better too :)

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 was considering this as well

@thaJeztah thaJeztah merged commit 97a6bf3 into docker:master Sep 23, 2024
98 checks passed
@thaJeztah thaJeztah added the containerd-integration Issues and PRs related to containerd integration label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants