-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/reference: stop, restart: add flag descriptions #5484
docs/reference: stop, restart: add flag descriptions #5484
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5484 +/- ##
===========================================
+ Coverage 43.17% 60.03% +16.86%
===========================================
Files 6 345 +339
Lines 227 23434 +23207
===========================================
+ Hits 98 14068 +13970
- Misses 123 8391 +8268
- Partials 6 975 +969 |
/cc @dvdksn ptal 🤗 |
Signed-off-by: Sebastiaan van Stijn <[email protected]>
35d3dde
to
6075303
Compare
The default timeout can be specified using the [`--stop-timeout`](https://docs.docker.com/reference/cli/docker/container/run/#stop-timeout) | ||
option when creating the container. If no default is configured for the container, | ||
the Daemon determines the default, and is 10 seconds for Linux containers, and | ||
30 seconds for Windows containers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH; not super happy with these sections; we should probably have a look at better descriptions for these (we have this in some other places as well).
It's a bit complicated to explain these bits
- container inherits default from image (which can be set through dockerfile)
- or overridden at runtime (
docker create
/docker run
) - or overridden when invoking these commands
- or otherwise use the daemon default (which can differ per platform)
Some of that could become more transparent if we had better separation between "desired config" and "actual config" (in which case we could make defaults visible in inspect
output), but we don't have that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- A picture of a cute animal (not mandatory but encouraged)