cli/command/container: set empty args in tests and discard output #5534
+33
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
area/testing
kind/bugfix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5534 +/- ##
==========================================
+ Coverage 60.53% 60.92% +0.39%
==========================================
Files 342 345 +3
Lines 23483 23491 +8
==========================================
+ Hits 14216 14313 +97
+ Misses 8292 8205 -87
+ Partials 975 973 -2 |
thaJeztah
changed the title
Benehiko
approved these changes
Oct 16, 2024
laurazard
reviewed
Oct 16, 2024
cli/command/container/utils_test.go
Outdated
Comment on lines
63
to
66
| for _, tc := range tests { | ||
| t.Run(tc.cid, func(t *testing.T) { | ||
| client := &fakeClient{waitFunc: waitFn, Version: api.DefaultVersion} | ||
|
|
There was a problem hiding this comment.
It's now using a separate client per test – was that an intentional change?
There was a problem hiding this comment.
Good catch; not really (I think I contemplated "parallel" tests for a second, but the overhead thereof didn't make much sense for this).
Let me change that back
There was a problem hiding this comment.
@laurazard updated; PTAL
Prevent some tests from failing when running from a pre-compiled testbinary, and discard output to make the output less noisy. Signed-off-by: Sebastiaan van Stijn <[email protected]>
=== RUN TestWaitExitOrRemoved
=== RUN TestWaitExitOrRemoved/normal-container
=== RUN TestWaitExitOrRemoved/give-me-exit-code-42
=== RUN TestWaitExitOrRemoved/i-want-a-wait-error
time="2024-10-13T18:48:14+02:00" level=error msg="Error waiting for container: removal failed"
=== RUN TestWaitExitOrRemoved/non-existent-container-id
time="2024-10-13T18:48:14+02:00" level=error msg="error waiting for container: no such container: non-existent-container-id"
--- PASS: TestWaitExitOrRemoved (0.00s)
--- PASS: TestWaitExitOrRemoved/normal-container (0.00s)
--- PASS: TestWaitExitOrRemoved/give-me-exit-code-42 (0.00s)
--- PASS: TestWaitExitOrRemoved/i-want-a-wait-error (0.00s)
--- PASS: TestWaitExitOrRemoved/non-existent-container-id (0.00s)
PASS
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
container_testfixes
branch
from
b7c142d
to
35d7b1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli/command/container: set empty args in tests and discard output
Prevent some tests from failing when running from a pre-compiled testbinary, and discard output to make the output less noisy.
cli/command/container: TestWaitExitOrRemoved use subtests
- A picture of a cute animal (not mandatory but encouraged)