Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit events for building images #11498

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

felixfontein
Copy link
Contributor

What I did
Right now docker compose build or docker compose up --build does not emit events. The only way to notice that something was built is by looking at stdout. The only case events are written (to stderr) is when using BuildKit in dry-mode (there's special code to emit some fake events in that case).

This PR makes building emit proper events (one before and one after building). This improves using docker compose from other programs. (Especially together with #11478.)

Related issue
Fixes #11403.

(not mandatory) A picture of a cute animal, if possible in relation to what you did
A cute cat with rather sharp claws, watch out when petting her

@felixfontein
Copy link
Contributor Author

@ndeloof could you maybe take a look at this PR at some point? Thanks :)

@felixfontein
Copy link
Contributor Author

@ndeloof can you take a look at this? Thanks.

@sfc-gh-kbregula
Copy link

Are these events also generated if the image is built by the docker compose watch command?

@felixfontein
Copy link
Contributor Author

I would assume so; I've never used docker compose watch or looked at how it works. But I would assume it uses the same code as docker compose up and docker compose build.

Signed-off-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Building images not visible in progress events, *except* in dry-run mode
2 participants