Add support for bind recursive #12210
Merged
+33
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
requested review from
a team,
glours and
jhrotko
and removed request for
a team
ndeloof
force-pushed
the
bind_recursive
branch
from
73cf9dc
to
ddbcace
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
bind_recursive
branch
from
ddbcace
to
e672d2b
Compare
jhrotko
reviewed
Oct 16, 2024
| // NonRecursive: false, FIXME missing from model ? | ||
| opts := &mount.BindOptions{ | ||
| Propagation: mount.Propagation(bind.Propagation), | ||
| CreateMountpoint: bind.CreateHostPath, |
There was a problem hiding this comment.
is this always defined? Do we need to so any checking for bind.CreateHostPath?
There was a problem hiding this comment.
this is a bool, defaults to true
glours
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add support for
bind.recursiveIntroduce
requireMountAPIto make it more explicit we rely on bind only when options do not require toRelated issue
close #11792
(not mandatory) A picture of a cute animal, if possible in relation to what you did