Fix or noqa B003 (assigning to os.environ doesn't do what you expect)

Signed-off-by: Aarni Koskela <[email protected]>
docker · Jun 6, 2023 · 86d47b8 · 86d47b8
1 parent c4b5cc3
commit 86d47b8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/tests/integration/credentials/utils_test.py b/tests/integration/credentials/utils_test.py
@@ -7,7 +7,7 @@
 @mock.patch.dict(os.environ)
 def test_create_environment_dict():
     base = {'FOO': 'bar', 'BAZ': 'foobar'}
-    os.environ = base
+    os.environ = base  # noqa: B003
     assert create_environment_dict({'FOO': 'baz'}) == {
         'FOO': 'baz', 'BAZ': 'foobar',
     }

diff --git a/tests/unit/client_test.py b/tests/unit/client_test.py
@@ -153,7 +153,8 @@ def setUp(self):
         self.os_environ = os.environ.copy()
 
     def tearDown(self):
-        os.environ = self.os_environ
+        os.environ.clear()
+        os.environ.update(self.os_environ)
 
     def test_from_env(self):
         """Test that environment variables are passed through to

diff --git a/tests/unit/utils_test.py b/tests/unit/utils_test.py
@@ -59,7 +59,8 @@ def setUp(self):
         self.os_environ = os.environ.copy()
 
     def tearDown(self):
-        os.environ = self.os_environ
+        os.environ.clear()
+        os.environ.update(self.os_environ)
 
     def test_kwargs_from_env_empty(self):
         os.environ.update(DOCKER_HOST='',