I30/svg in badge image background sometimes fails to render #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now handles when the calculated fraction is NaN, something which occured when a badge had no requirements. The current handling is to set the fraction to one, meaning that the badge shows up as completed.
Espenbfo
reviewed
Feb 22, 2022
| @@ -29,33 +29,33 @@ protected override void OnInitialized() | |||
| Console.WriteLine($"{id}, {description}, {image}, {list}, {logo}, {complete}"); | |||
| } | |||
|
|
|||
| private double RightBorderY(double deg) | |||
| public double RightBorderY(double deg) | |||
There was a problem hiding this comment.
Is it necessary to make these public?
| { | ||
| return 75.0; | ||
| } | ||
| return Math.Sin(-deg * Math.PI * 2 + Math.PI) * 75 + 75; | ||
| } | ||
| private double RightBorderX(double deg) | ||
| public double RightBorderX(double deg) |
| { | ||
| return 150; | ||
| } | ||
| return Math.Cos(-deg * Math.PI * 2 + Math.PI) * 75 + 75; | ||
| } | ||
| private double LeftBorderY(double deg) | ||
| public double LeftBorderY(double deg) |
| { | ||
| return 150.0; | ||
| } | ||
| return Math.Sin(-deg * Math.PI * 2 + Math.PI) * 75 + 75; | ||
| } | ||
| private double LeftBorderX(double deg) | ||
| public double LeftBorderX(double deg) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.