Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistent usage of node vs nodename #115

Closed
wants to merge 1 commit into from

Conversation

davhdavh
Copy link

Pull Request

Required Fields

🔎 What kind of change is it?

  • fix

🎯 What has been changed and why do we need it?

  • updated node to nodename as this is the documented field to store the name of the node

before:
image
after:
image

@davhdavh davhdavh requested a review from dotdc as a code owner July 25, 2024 05:34
@dotdc
Copy link
Owner

dotdc commented Jul 27, 2024

Hi @davhdavh,

This PR will break the dashboard on my side and for most users.
You should try: broken panels on k8s-views-nodes due to the nodename label

Closing, but you can open an issue if the problem persists.

@dotdc dotdc closed this Jul 27, 2024
@davhdavh
Copy link
Author

Err the current chart doesn't even use nodename. Thus the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants