fix: using empty image label for container metrics #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Calvert <[email protected]>
|
🎉 This PR is included in version 2.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
buroa
added a commit
to buroa/k8s-gitops
that referenced
this pull request
Oct 3, 2024
…s / pods (29 → 31)" This reverts commit 53aa762. See: dotdc/grafana-dashboards-kubernetes#122
|
Hey @dotdc this seemed to break all my dashboards in my environment. Can we please revert this? |
buroa
added a commit
to buroa/grafana-dashboards-kubernetes
that referenced
this pull request
Oct 3, 2024
This reverts commit 6a5ef77.
|
Can confirm these dashboards don't show any data with this change. Please revert. |
dotdc
added a commit
that referenced
this pull request
Oct 3, 2024
Co-authored-by: David Calvert <[email protected]> Co-authored-by: Devin Buhl <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Required Fields
🔎 What kind of change is it?
🎯 What has been changed and why do we need it?
image!=""toimage=""oncontainer_*metricsWe need this because it seems slightly more accurate and avoids a bug where memory get doubled.
Users should expect a small TSDB data change like in the graph below:
Optional Fields
✔️ Which issue(s) this PR fixes?