fix(apiserver-duration): compute average of duration #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without the fix, the dashboards show the cumulative duration
of all buckets, which doesn't make much sense.
with the fix, we divide the total duration by the number of requests,
which yields the average latency. note that we could also have used
`_duration_seconds_bucket{le="+Inf"}` instead of `duration_seconds_sum`
Signed-off-by: Clément Nussbaumer <[email protected]>
|
Hi @clementnuss, Sorry I didn't have time to test this but sounds good, so I'll merge as is. Thank you for your contribution! |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without the fix, the dashboards show the cumulative duration of all buckets, which doesn't make much sense. (we plot
sum by (instance)of buckets, and there are ~10 buckets (le="0.05", le="0.1", ..., le="+Inf"). this doesn't represent the latency of the API server.with the fix, we divide the total duration by the number of requests, which yields the average latency. note that we could also have used
_duration_seconds_bucket{le="+Inf"}instead ofduration_seconds_sumPull Request
Required Fields
🔎 What kind of change is it?
🎯 What has been changed and why do we need it?
before:
after:
