Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(k8s-views-global.json): added cluster variable #78

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

dotdc
Copy link
Owner

@dotdc dotdc commented Dec 18, 2023

Pull Request

Required Fields

🔎 What kind of change is it?

  • feat

🎯 What has been changed and why do we need it?

  • Added the ability to filter on cluster when it's in use

Optional Fields

✔️ Which issue(s) this PR fixes?

@dotdc dotdc self-assigned this Dec 18, 2023
@jkroepke
Copy link
Contributor

cluster as multi-values field is not an good idea.

The if there is the same namespace on multiple clusters (e.g. kube-system, flux-system), the CPU Utilization by namespace chart shows very high values.

Instead: sum(rate(container_cpu_usage_seconds_total{image!="", cluster=~"$cluster"}[$__rate_interval])) by (namespace), use sum(rate(container_cpu_usage_seconds_total{image!="", cluster=~"$cluster"}[$__rate_interval])) by (cluster, namespace) and adjust the legend {{ cluster }} {{ namespace }} or disallow multi-value of cluster.

@dotdc
Copy link
Owner Author

dotdc commented Dec 18, 2023

Disabled multi for the cluster variable, as it's a less intrusive change for now.

Copy link
Contributor

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dotdc dotdc merged commit 3d99847 into master Dec 18, 2023
1 check passed
@dotdc dotdc deleted the feat/added-cluster-var-to-k8s-views-global.json branch December 18, 2023 20:21
dotdc added a commit that referenced this pull request Dec 19, 2023
dotdc added a commit that referenced this pull request Dec 19, 2023
@dotdc
Copy link
Owner Author

dotdc commented Apr 25, 2024

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dotdc dotdc added the released label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants