Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Maui.Graphics.Gtk: track api changes Maui.Graphics version 6 #469

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lytico
Copy link
Contributor

@lytico lytico commented Jul 1, 2022

some refactoring to get Maui.Graphics.Gtk working again.

@mattleibow
Copy link
Member

@lytico Thanks for this PR.

We just merged dotnet/maui#8739 and unfortunately when we started the process we only moved the things that were building and releasing.

However, this is no big issue. I was wondering if you would be interested in taking these changes you made and make a larger PR in https://github.com/dotnet/maui with all of Gtk things?

The reason we moved was having 2 repos was cumbersome and we also ended up neglecting issues and PRs here. Moving forward, we would like to ensure that we show the same support for maui graphics as we do maui.

The new repo has a bunch of extra things, but the src/Graphics folder is basically the root of this repo.

So if you wanted to make this larger PR, it would just be a matter of cloning that repo and copying some folders:

  • src/Microsoft.Maui.Graphics.Gtk
  • samples/GraphicsTester.Gtk

To integrate into the maui build system would just be a few things:

  • add the 2 new projects to the Microsoft.Maui.sln solution
  • add the 2 new projects to the Microsoft.Maui.Graphics.slnf filter

Moving forward, devs will still not need to care about the rest of the maui repo as they can just use the Microsoft.Maui.Graphics.slnf filter and work there. There is no dependency on maui - just in name for marketing - since maui depends on graphics.

@lytico
Copy link
Contributor Author

lytico commented Jul 27, 2022

@mattleibow

I was wondering if you would be interested in taking these changes you made and make a larger PR in https://github.com/dotnet/maui with all of Gtk things?

yes, just give me some time. maybe not until august.

@Slesa
Copy link

Slesa commented Sep 19, 2022

@mattleibow How can I help?

@lytico
Copy link
Contributor Author

lytico commented Sep 20, 2022

@Slesa the pr is already moved to dotnet/maui#9522 and waiting for merge.

if you want to do some implementation, some missing features are listed here:
https://github.com/lytico/Microsoft.Maui.Graphics/issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants