Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added azure cicd via gha #197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bradygaster
Copy link
Member

No description provided.

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine if it works

@adityamandaleeka
Copy link
Member

@bradygaster Can we have this instead spit the YAML from the CI job and then have it run provision and deploy using that?

@jamesmontemagno
Copy link
Member

@bradygaster updates if you are able to split this per ^

@isaacrlevin
Copy link

@adityamandaleeka are we going to have this PR in the base repo? If yes, are there going to be a doc to define the pre-reqs to get this to work?

@bradygaster
Copy link
Member Author

@jamesmontemagno how should i split it? provision and deploy as separate files/jobs?

@adityamandaleeka
Copy link
Member

adityamandaleeka commented Mar 28, 2024

@bradygaster I think there was a typo above. The change we want to make is to spit (emit) the YAML (the few lines you have in azure.yaml) in the CI job itself and then use it in the subsequent parts. The script/flow you have already is good 😄

@isaacrlevin Not sure what you mean by base repo (I assume you mean this repo?). This is just a CI job but we do have instructions for azd deployment in the README: https://github.com/dotnet/eShop?tab=readme-ov-file#use-azure-developer-cli

@isaacrlevin
Copy link

I was just curious if we plan to actually have a version of eShop in Azure. If not, do we need to have the Action in the repo at all.

@adityamandaleeka
Copy link
Member

I think it's a good way for us to ensure we don't regress the ability to deploy a 'vanilla' Aspire app to Azure.

@jamesmontemagno
Copy link
Member

Should we actually deploy it? if we do should we azd down at the end? what sub would we put this in?

@bradygaster
Copy link
Member Author

Not sure we should azd down at the end. Seems like if someone's setting it up they'd know they'll need to tear it down later.

@isaacrlevin
Copy link

isaacrlevin commented May 7, 2024

Probably should just put this in a sample or doc on "one of the ways" to deploy Aspire to Azure. That way you can outline steps to add secrets to repo and add a "Delete Resources" section that calls out azd down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants