made FilterQuality configurable for Resizetizer #25686
Conversation
| @@ -124,6 +128,9 @@ public static ResizeImageInfo Parse(ITaskItem image) | |||
| info.ForegroundFilename = fgFileInfo.FullName; | |||
| } | |||
|
|
|||
| if (Enum.TryParse<SKFilterQuality>(image.GetMetadata("FilterQuality"), out var filterQuality)) | |||
There was a problem hiding this comment.
we might have to add the docs here how to implement in the MauiImage and also available values for the FilterQuality
There was a problem hiding this comment.
Done. See dotnet/docs-maui#2604
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@jsuarezruiz I think that the failing CI is unrelated to my changes. |
|
/rebase |
github-actions
bot
force-pushed
the
br_25683_Resizetizer_make_FilterQuality_configurable
branch
from
24ba86c
to
7cfbdb5
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
How does this fix the issue? The filter quality should just be configuring the antialiasing and similar. The image should be the same size. Are the generated images smaller after this PR? |
|
This PR enables us to set the quality to 'None' which was the old default behavior. For our case, this reduces our app size tremendously. Later on we will try to fix our image resolutions to have a working setup with better antialiasing. But for the sake of keeping the old behavior, we need this PR. |
|
/rebase |
github-actions
bot
force-pushed
the
br_25683_Resizetizer_make_FilterQuality_configurable
branch
from
7cfbdb5
to
69b1556
Compare
|
/azp run maui-public maui-uitests-public |
|
No pipelines are associated with this pull request. |
|
/azp run maui-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Build seems to be failing ...
D:\a\_work\1\s\eng\ILRepack.targets(126,3): error MSB3073: The command ""D:\a\_work\1\s\eng\ILRepack.exe" /out:"D:\a\_work\1\s\artifacts\bin\Resizetizer\Release\netstandard2.0\ILRepacked\Microsoft.Maui.Resizetizer.dll" "D:\a\_work\1\s\artifacts\bin\Resizetizer\Release\netstandard2.0\Microsoft.Maui.Resizetizer.dll" /ver:42.42.42.42424 /internalize /keyfile:"D:\a\_work\1\s\eng/microsoft.maui.controls.snk" /lib:"C:\Users\cloudtest\.nuget\packages\netstandard.library\2.0.3\build\netstandard2.0\ref"" exited with code 1. [D:\a\_work\1\s\src\SingleProject\Resizetizer\src\Resizetizer.csproj]
22 Warning(s)
1 Error(s)
|
@rmarinho As I already included this PR in our custom build, I am not sure if my changes caused these build issues. Could you provide more detail on the build failure? |
|
This PR has some value in and of itself - the attribute will allow people to decided to render images at a lower quality. But, the only reason today is because higher quality is a large png that was upscaled. See more: #25750 (comment) I am thinking that maybe we first evaluate whether we should be upscaling (buth this app and resizetizer as a whole). |
Description of Change
Made
FilterQualityconfigurable for Resizetizer. Default value isSKFilterQuality.High(like it was hard coded before).Issues Fixed
Fixes #25750
Documentation
Adapted documentation in dotnet/docs-maui#2604