Fix vb array size (#1480)

* Fix vb array size

* More fixes

* More fixes

* More fixes

* More fixes

* Update snippets/visualbasic/VS_Snippets_CFX/s_uechannels/vb/clientsnippets.vb

Co-Authored-By: Ron Petrusha <[email protected]>

* Update clientsnippets.vb

snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData ConstraintCollection.Add4 Example/VB/source.vb

@@ -14,8 +14,8 @@ Module Module1
     Private Sub AddForeignConstraint( _
     ByVal dataSet As DataSet, ByVal table As DataTable)
         Try
-            Dim parentColumns(2) As DataColumn
-            Dim childColumns(2) As DataColumn
+            Dim parentColumns(1) As DataColumn
+            Dim childColumns(1) As DataColumn
             ' Get the tables from the DataSet.
             Dim customersTable As DataTable = _
                 dataSet.Tables("Customers")

snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData DataSet.GetChanges Example/VB/source.vb

@@ -21,7 +21,7 @@ Private Sub DemonstrateMerge()
         Type.GetType("System.Int32"), "")
 
     ' Create DataColumn array to set primary key.
-    Dim keyColumn(1) As DataColumn
+    Dim keyColumn(0) As DataColumn
     Dim row As DataRow
 
     ' Create variable for temporary DataSet. 

snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData DataSet.Merge Example/VB/source.vb

@@ -18,7 +18,7 @@ Public Class Form1
      Dim itemColumn As New DataColumn("Item", Type.GetType("System.Int32"))
 
      ' DataColumn array to set primary key.
-     Dim keyColumn(1) As DataColumn
+     Dim keyColumn(0) As DataColumn
      Dim row As DataRow
 
      ' Create variable for temporary DataSet. 

snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData DataSet.Merge2 Example/VB/source.vb

@@ -21,7 +21,7 @@ Private Sub DemonstrateMergeMissingSchema()
         Type.GetType("System.Int32"))
 
     ' DataColumn array to set primary key.
-    Dim keyColumn(1) As DataColumn
+    Dim keyColumn(0) As DataColumn
     Dim row As DataRow
 
     ' Create variable for temporary DataSet. 

snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData DataSet.Merge3 Example/VB/source.vb

@@ -25,7 +25,7 @@ Private Sub DemonstrateMergeTable()
     table.Columns.Add(c2)
 
     ' DataColumn array to set primary key.
-    Dim keyCol(1) As DataColumn
+    Dim keyCol(0) As DataColumn
 
     ' Set primary key column.
     keyCol(0) = c1

snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData DataSet.Merge4 Example/VB/source.vb

@@ -28,7 +28,7 @@ Private Sub DemonstrateMergeTableAddSchema()
     table.Columns.Add(itemColumn)
 
     ' DataColumn array to set primary key.
-    Dim keyCol(1) As DataColumn
+    Dim keyCol(0) As DataColumn
 
     ' Set primary key column.
     keyCol(0) = idColumn

snippets/visualbasic/VS_Snippets_ADO.NET/DataWorks OleDb.JetAutonumberMerge/VB/source.vb

@@ -55,7 +55,7 @@ Class Class1
             categories.Columns.Add(column)
 
             ' Set the primary key on CategoryID.
-            Dim pKey(1) As DataColumn
+            Dim pKey(0) As DataColumn
             pKey(0) = categories.Columns("CategoryID")
             categories.PrimaryKey = pKey
 

snippets/visualbasic/VS_Snippets_CFX/s_msmqtowcf/vb/client.vb

@@ -26,7 +26,7 @@ Module Client
         lineItem2.quantity = 890
         lineItem2.unitCost = 45.89F
 
-        Dim lineItems(2) As PurchaseOrderLineItem
+        Dim lineItems(1) As PurchaseOrderLineItem
         lineItems(0) = lineItem1
         lineItems(1) = lineItem2
         po.orderLineItems = lineItems

snippets/visualbasic/VS_Snippets_CFX/s_uechannels/vb/clientsnippets.vb

@@ -7,19 +7,19 @@ Public Class clientSnippets
 
     Public Shared Sub Snippet11()
         ' <Snippet11>
-        Dim binding As CustomBinding = New CustomBinding()
+        Dim binding As New CustomBinding()
         binding.Elements.Add(New HttpTransportBindingElement())
-        Dim paramCollection As BindingParameterCollection = New BindingParameterCollection()
+        Dim paramCollection As New BindingParameterCollection()
 
         binding.CanBuildChannelFactory(Of IRequestChannel)(paramCollection)
         ' </Snippet11>
     End Sub
 
     Public Shared Sub Snippet12()
         ' <Snippet12>
-        Dim binding As CustomBinding = New CustomBinding()
-        Binding.Elements.Add(New HttpTransportBindingElement())
-        Dim bindingParameters(2) As Object
+        Dim binding As New CustomBinding()
+        binding.Elements.Add(New HttpTransportBindingElement())
+        Dim bindingParameters(1) As Object
 
         binding.CanBuildChannelFactory(Of IRequestChannel)(bindingParameters)
         ' </Snippet12>
@@ -29,11 +29,11 @@ Public Class clientSnippets
         ' <Snippet3>
         Dim binding As CustomBinding = New CustomBinding()
         binding.Elements.Add(New HttpTransportBindingElement())
-        Dim bindingParams(2) As Object
+        Dim bindingParams(1) As Object
 
         Dim factory As IChannelFactory(Of IRequestChannel) = binding.BuildChannelFactory(Of IRequestChannel)(bindingParams)
         factory.Open()
-        Dim address As EndpointAddress = New EndpointAddress("http://localhost/channelApp/service")
+        Dim address As New EndpointAddress("http://localhost/channelApp/service")
         Dim channel As IRequestChannel = factory.CreateChannel(address)
         channel.Open()
         Dim request As Message = Message.CreateMessage(MessageVersion.Default, "hello")

snippets/visualbasic/VS_Snippets_CFX/s_uechannels/vb/servicesnippets.vb

@@ -40,7 +40,7 @@ Namespace UE.Samples.Channel
             ' <Snippet5>
             Dim binding As CustomBinding = New CustomBinding()
             binding.Elements.Add(New HttpTransportBindingElement())
-            Dim bindingParameters(2) As Object
+            Dim bindingParameters(1) As Object
 
             Dim listener As IChannelListener(Of IReplyChannel)
             listener = binding.BuildChannelListener(Of IReplyChannel)(bindingParameters)
@@ -69,7 +69,7 @@ Namespace UE.Samples.Channel
             ' <Snippet6>
             Dim binding As CustomBinding = New CustomBinding()
             binding.Elements.Add(New HttpTransportBindingElement())
-            Dim bindingParameters(2) As Object
+            Dim bindingParameters(1) As Object
             Dim listener As IChannelListener(Of IReplyChannel)
             listener = binding.BuildChannelListener(Of IReplyChannel)(New Uri("http://localhost/channelApp"), bindingParameters)
             ' </Snippet6>
@@ -89,7 +89,7 @@ Namespace UE.Samples.Channel
             ' <Snippet8>
             Dim binding As CustomBinding = New CustomBinding()
             binding.Elements.Add(New HttpTransportBindingElement())
-            Dim bindingParameters(2) As Object
+            Dim bindingParameters(1) As Object
             Dim listener As IChannelListener(Of IReplyChannel)
             listener = binding.BuildChannelListener(Of IReplyChannel)(New Uri("http://localhost/channelApp"), "http://localhost/channelApp/service", bindingParameters)
             ' </Snippet8>
@@ -109,7 +109,7 @@ Namespace UE.Samples.Channel
             ' <Snippet10>
             Dim binding As CustomBinding = New CustomBinding()
             binding.Elements.Add(New HttpTransportBindingElement())
-            Dim bindingParameters(2) As Object
+            Dim bindingParameters(1) As Object
             Dim listener As IChannelListener(Of IReplyChannel)
             listener = binding.BuildChannelListener(Of IReplyChannel)(New Uri("http://localhost/channelApp"), "http://localhost/channelApp/service", ListenUriMode.Explicit, bindingParameters)
             '</Snippet10>
@@ -129,7 +129,7 @@ Namespace UE.Samples.Channel
             ' <Snippet14>
             Dim binding As CustomBinding = New CustomBinding()
             binding.Elements.Add(New HttpTransportBindingElement())
-            Dim bindingParameters(2) As Object
+            Dim bindingParameters(1) As Object
 
             binding.CanBuildChannelFactory(Of IReplyChannel)(bindingParameters)
             '</Snippet14>

snippets/visualbasic/VS_Snippets_CFX/s_wcftomsmq/vb/snippets.vb

@@ -29,7 +29,7 @@ Class Snippets
         lineItem2.quantity = 890
         lineItem2.unitCost = 45.89F
 
-        Dim lineItems(2) As PurchaseOrderLineItem
+        Dim lineItems(1) As PurchaseOrderLineItem
         lineItems(0) = lineItem1
         lineItems(1) = lineItem2
 

snippets/visualbasic/VS_Snippets_CFX/samlattribute/vb/source.vb

@@ -319,7 +319,7 @@ Namespace Microsoft.ServiceModel.Samples.Federation
         '/ <returns>Proof Token</returns>
         Protected Shared Function CreateProofToken(ByVal keySize As Integer) As BinarySecretSecurityToken
             ' Create an array to store the key bytes.
-            Dim key(keySize / 8) As Byte
+            Dim key(keySize / 8 - 1) As Byte
             ' Create some random bytes.
             Dim random As New RNGCryptoServiceProvider()
             random.GetNonZeroBytes(key)
@@ -763,7 +763,7 @@ Namespace Microsoft.ServiceModel.Samples.Federation
                     Dim nBytes As Integer = xr.ReadContentAsBase64(temp, 0, temp.Length)
 
                     ' Allocate a new array of the correct size to hold the provided entropy.
-                    Dim entropy(nBytes) As Byte
+                    Dim entropy(nBytes - 1) As Byte
 
                     ' Copy the entropy from the temporary array into the new array.
                     Dim i As Integer
@@ -1029,9 +1029,9 @@ Namespace Microsoft.ServiceModel.Samples.Federation
         Public Shared Function ComputeCombinedKey(ByVal requestorEntropy() As Byte, ByVal issuerEntropy() As Byte, ByVal keySize As Integer) As Byte()
             Dim kha As KeyedHashAlgorithm = New HMACSHA1(requestorEntropy, True)
 
-            Dim key(keySize / 8) As Byte ' Final key
+            Dim key(keySize / 8 - 1) As Byte ' Final key
             Dim a As Byte() = issuerEntropy ' A(0)
-            Dim b(kha.HashSize / 8 + a.Length) As Byte ' Buffer for A(i) + seed
+            Dim b(kha.HashSize / 8 + a.Length - 1) As Byte ' Buffer for A(i) + seed
             Dim i As Integer
 
             While i < key.Length

snippets/visualbasic/VS_Snippets_CFX/wf_samples/vb/snippets.vb

@@ -1787,7 +1787,7 @@ Namespace WF_Snippets
 
             Public Function SerializeToolboxItem(ByVal toolboxItem As ToolboxItem) As Object Implements IToolboxService.SerializeToolboxItem
                 Dim components As IComponent() = toolboxItem.CreateComponents()
-                Dim activities(components.Length) As Activity
+                Dim activities(components.Length - 1) As Activity
                 components.CopyTo(activities, 0)
 
                 Return CompositeActivityDesigner.SerializeActivitiesToDataObject(Me.provider, activities)

snippets/visualbasic/VS_Snippets_CFX/wf_samples/vb/snippets24.vb

@@ -1140,7 +1140,7 @@ Namespace WF_Snippets
                 ' file opened for shared reads but no writes by anyone
                 fileStream = New FileStream(filename, FileMode.Open, FileAccess.Read, FileShare.Read)
                 fileStream.Seek(0, SeekOrigin.Begin)
-                Dim workflowBytes((CType(fileStream.Length, Integer))) As Byte
+                Dim workflowBytes(CInt(fileStream.Length - 1)) As Byte
 
                 ' get the serialized form
                 fileStream.Read(workflowBytes, 0, workflowBytes.Length)

snippets/visualbasic/VS_Snippets_CLR/AppDomain_LoadRaw/VB/loadraw.vb

@@ -32,7 +32,7 @@ Module Test
    ' Loads the content of a file to a byte array. 
    Function loadFile(filename As String) As Byte()
       Dim fs As New FileStream(filename, FileMode.Open)
-      Dim buffer(CInt(fs.Length)) As Byte
+      Dim buffer(CInt(fs.Length - 1)) As Byte
       fs.Read(buffer, 0, buffer.Length)
       fs.Close()
 

snippets/visualbasic/VS_Snippets_CLR/ArrayTypeMisMatch_Constructor1/VB/arraytypemismatch_constructor1.vb

@@ -25,10 +25,10 @@ Public Class ArrayTypeMisMatchConst
 
    Shared Sub Main()
       Try
-         Dim myStringArray(2) As String
+         Dim myStringArray(1) As String
          myStringArray.SetValue("Jones", 0)
          myStringArray.SetValue("John", 1)
-         Dim myIntArray(2) As Integer
+         Dim myIntArray(1) As Integer
          Dim myArrayType As New ArrayTypeMisMatchConst()
          myArrayType.CopyArray(myStringArray, myIntArray)
       Catch e As ArrayTypeMismatchException

snippets/visualbasic/VS_Snippets_CLR/ArrayTypeMisMatch_Constructor2/VB/arraytypemismatch_constructor2.vb

@@ -26,10 +26,10 @@ Public Class ArrayTypeMisMatchConst
 
    Shared Sub Main()
       Try
-         Dim myStringArray(2) As String
+         Dim myStringArray(1) As String
          myStringArray.SetValue("Jones", 0)
          myStringArray.SetValue("John", 1)
-         Dim myIntArray(2) As Integer
+         Dim myIntArray(1) As Integer
          Dim myArrayType As New ArrayTypeMisMatchConst()
          myArrayType.CopyArray(myStringArray, myIntArray)
       Catch e As ArrayTypeMismatchException

snippets/visualbasic/VS_Snippets_CLR/ArrayTypeMisMatch_Constructor3/VB/arraytypemismatch_constructor3.vb

@@ -25,10 +25,10 @@ Public Class ArrayTypeMisMatchConst
 
    Shared Sub Main()
       Try
-         Dim myStringArray(2) As String
+         Dim myStringArray(1) As String
          myStringArray.SetValue("Jones", 0)
          myStringArray.SetValue("John", 1)
-         Dim myIntArray(2) As Integer
+         Dim myIntArray(1) As Integer
          Dim myArrayType As New ArrayTypeMisMatchConst()
          myArrayType.CopyArray(myStringArray, myIntArray)
       Catch e As ArrayTypeMismatchException

snippets/visualbasic/VS_Snippets_CLR/AssemblyName_SetPublicKey/VB/assemblyname_setpublickey.vb

@@ -63,7 +63,7 @@ Public Class AssemblyName_CodeBase
       myAssemblyName.Flags = AssemblyNameFlags.PublicKey
       ' Get the whole contents of the 'PublicKey.snk' into a byte array.
       Dim publicKeyStream As FileStream = File.Open("PublicKey.snk", FileMode.Open)
-      Dim publicKey(publicKeyStream.Length) As Byte
+      Dim publicKey(publicKeyStream.Length - 1) As Byte
       publicKeyStream.Read(publicKey, 0, CInt(publicKeyStream.Length))
       ' Provide the assembly with a public key.
       myAssemblyName.SetPublicKey(publicKey)

snippets/visualbasic/VS_Snippets_CLR/Asynchronous_File_IO_async/vb/example2.vb

@@ -14,7 +14,7 @@ Class MainWindow
     End Sub
 
     Public Async Function CopyFilesAsync(Source As StreamReader, Destination As StreamWriter) As Task
-        Dim buffer(4096) As Char
+        Dim buffer(4095) As Char
         Dim numRead As Integer
 
         numRead = Await Source.ReadAsync(buffer, 0, buffer.Length)

snippets/visualbasic/VS_Snippets_CLR/CertInfo/VB/certinfo.vb

@@ -10,7 +10,7 @@ Class CertInfo
     Friend Shared Function ReadFile(ByVal fileName As String) As Byte()
         Dim f As New FileStream(fileName, FileMode.Open, FileAccess.Read)
         Dim size As Integer = Fix(f.Length)
-        Dim data(size) As Byte
+        Dim data(size - 1) As Byte
         size = f.Read(data, 0, size)
         f.Close()
         Return data

snippets/visualbasic/VS_Snippets_CLR/CodeStatementCollectionExample/VB/class1.vb

@@ -44,7 +44,7 @@ Public Class Class1
         '<Snippet6>
         ' Copies the contents of the collection beginning at index 0 to the specified CodeStatement array.
         ' 'statements' is a CodeStatement array.
-        Dim statementArray(collection.Count) As CodeStatement
+        Dim statementArray(collection.Count - 1) As CodeStatement
         collection.CopyTo(statementArray, 0)
         '</Snippet6>
 

snippets/visualbasic/VS_Snippets_CLR/Cryptography.3DES.Createstring.Memory/VB/memoryexample.vb

@@ -85,7 +85,7 @@ Module TripleDESPSample
                                               CryptoStreamMode.Read)
 
             ' Create buffer to hold the decrypted data.
-            Dim fromEncrypt(Data.Length) As Byte
+            Dim fromEncrypt(Data.Length - 1) As Byte
 
             ' Read the decrypted data out of the crypto stream
             ' and place it into the temporary buffer.

snippets/visualbasic/VS_Snippets_CLR/Cryptography.DES.Create.Memory/VB/memoryexample.vb

@@ -83,7 +83,7 @@ Module DESSample
                                               CryptoStreamMode.Read)
 
             ' Create buffer to hold the decrypted data.
-            Dim fromEncrypt(Data.Length) As Byte
+            Dim fromEncrypt(Data.Length - 1) As Byte
 
             ' Read the decrypted data out of the crypto stream
             ' and place it into the temporary buffer.

snippets/visualbasic/VS_Snippets_CLR/Cryptography.DES.Createstring.Memory/VB/memoryexample.vb

@@ -85,7 +85,7 @@ Module DESPSample
                                               CryptoStreamMode.Read)
 
             ' Create buffer to hold the decrypted data.
-            Dim fromEncrypt(Data.Length) As Byte
+            Dim fromEncrypt(Data.Length - 1) As Byte
 
             ' Read the decrypted data out of the crypto stream
             ' and place it into the temporary buffer.

snippets/visualbasic/VS_Snippets_CLR/Cryptography.DESCSP.CreateEncryptor.Memory/VB/memoryexample.vb

@@ -77,7 +77,7 @@ Module DESCSPSample
                                               CryptoStreamMode.Read)
 
             ' Create buffer to hold the decrypted data.
-            Dim fromEncrypt(Data.Length) As Byte
+            Dim fromEncrypt(Data.Length - 1) As Byte
 
             ' Read the decrypted data out of the crypto stream
             ' and place it into the temporary buffer.

snippets/visualbasic/VS_Snippets_CLR/Cryptography.RC2.Create.Memory/VB/memoryexample.vb

@@ -83,7 +83,7 @@ Module RC2Sample
                                               CryptoStreamMode.Read)
 
             ' Create buffer to hold the decrypted data.
-            Dim fromEncrypt(Data.Length) As Byte
+            Dim fromEncrypt(Data.Length - 1) As Byte
 
             ' Read the decrypted data out of the crypto stream
             ' and place it into the temporary buffer.

snippets/visualbasic/VS_Snippets_CLR/Cryptography.RC2.Createstring.Memory/VB/memoryexample.vb

@@ -85,7 +85,7 @@ Module RC2PSample
                                               CryptoStreamMode.Read)
 
             ' Create buffer to hold the decrypted data.
-            Dim fromEncrypt(Data.Length) As Byte
+            Dim fromEncrypt(Data.Length - 1) As Byte
 
             ' Read the decrypted data out of the crypto stream
             ' and place it into the temporary buffer.

snippets/visualbasic/VS_Snippets_CLR/Cryptography.RC2CryptoServiceProvider/VB/example.vb

@@ -33,7 +33,7 @@ Module MyMainModule
         Dim msDecrypt As New MemoryStream(encryptedBytes)
         Dim csDecrypt As New CryptoStream(msDecrypt, rc2CSP.CreateDecryptor(rc2CSP.Key, rc2CSP.IV), CryptoStreamMode.Read)
 
-        Dim unencryptedBytes(originalBytes.Length) As Byte
+        Dim unencryptedBytes(originalBytes.Length - 1) As Byte
 
         'Read the data out of the crypto stream.
         csDecrypt.Read(unencryptedBytes, 0, unencryptedBytes.Length)

snippets/visualbasic/VS_Snippets_CLR/DPAPI-HowTO/vb/sample.vb

@@ -177,7 +177,7 @@ Public Module MemoryProtectionSample
         End If
 
 
-        Dim inBuffer(Length) As Byte
+        Dim inBuffer(Length - 1) As Byte
         Dim outBuffer() As Byte
 
         ' Read the encrypted data from a stream.

snippets/visualbasic/VS_Snippets_CLR/FInfo Open1/VB/finfo open1.vb

@@ -21,7 +21,7 @@ Public Class Test
 
         'Open the stream and read it back.
         fs = fi.Open(FileMode.Open)
-        Dim b(1024) As Byte
+        Dim b(1023) As Byte
         Dim temp As UTF8Encoding = New UTF8Encoding(True)
         Do While fs.Read(b, 0, b.Length) > 0
             Console.WriteLine(temp.GetString(b))

snippets/visualbasic/VS_Snippets_CLR/FInfo Open2/VB/finfo open2.vb

@@ -23,7 +23,7 @@ Public Class Test
 
 		'Open the stream and read it back.
 		fs = fi.Open(FileMode.Open, FileAccess.Read)
-		Dim b(1024) As byte
+		Dim b(1023) As byte
 		Dim temp As UTF8Encoding = New UTF8Encoding(true)
 
 		Do While fs.Read(b,0,b.Length) > 0

snippets/visualbasic/VS_Snippets_CLR/FInfo OpenRead/VB/finfo openread.vb

@@ -21,7 +21,7 @@ Public Class Test
 
         'Open the stream and read it back.
         fs = fi.OpenRead()
-        Dim b(1024) As Byte
+        Dim b(1023) As Byte
         Dim temp As UTF8Encoding = New UTF8Encoding(True)
 
         Do While fs.Read(b, 0, b.Length) > 0