fix(lvm): clean up whitespace in messages #2672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
modules
|
@teigland Fedora is using https://github.com/dracut-ng/dracut-ng . Would you consider uploading it there. Thanks ! |
This has to be a bot, there is no other explanation. |
The lvm module has been printing messages with whitespace damage: Scanning devices sda sdb for LVM logical volumes vg/root vg/swap Remove the trailing space after the final device name, and remove the newlines between LV names. The message above becomes: Scanning devices sda sdb for LVM logical volumes vg/root vg/swap (The same change is made to the VG activation message.)
teigland
force-pushed
the
lvm-cleanup-msg
branch
from
88dedb6
to
4e6d3b1
Compare
Oh, now we know what it is, and it's worse than a bot... though I'm not surprised (facepalm) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lvm module has been printing messages with whitespace damage:
Scanning devices sda sdb for LVM logical volumes vg/root
vg/swap
Remove the trailing space after the final device name, and remove the newlines between LV names. The message above becomes:
Scanning devices sda sdb for LVM logical volumes vg/root vg/swap
Checklist