-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #73
Open
jsoref
wants to merge
7
commits into
drone:master
Choose a base branch
from
jsoref:spelling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Spelling #73
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1b4f7e4
spelling: ciphertext
jsoref d63742a
spelling: fulfil
jsoref 3a7c1a3
spelling: permanently
jsoref f3fdac5
spelling: pipeline
jsoref abd71ec
spelling: rollback
jsoref effc998
spelling: todo
jsoref 93a8966
spelling: validator
jsoref File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,7 +46,7 @@ func TestHandler(t *testing.T) { | |
|
||
want := &drone.Config{ | ||
Kind: "drone.v1.yaml", | ||
Data: "pipeilne: []", | ||
Data: "pipeline: []", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. notable |
||
} | ||
plugin := &mockPlugin{ | ||
res: want, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,7 +48,7 @@ func Encrypt(plaintext []byte, key *[32]byte) (ciphertext []byte, err error) { | |
return gcm.Seal(nonce, nonce, plaintext, nil), nil | ||
} | ||
|
||
// Decrypt decrypts the raw, unencoded cihpertext with the provided key. | ||
// Decrypt decrypts the raw, unencoded ciphertext with the provided key. | ||
func Decrypt(ciphertext []byte, key *[32]byte) (plaintext []byte, err error) { | ||
block, err := aes.NewCipher(key[:]) | ||
if err != nil { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hanging comment about the file that's renamed below here... The package internally calls itself |
||
|
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notable