Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #73

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ docker run -it --rm -v "$(pwd)":/usr/local/src/your-app githubchangeloggenerator

You can generate a token by logging into your GitHub account and going to Settings -> Personal access tokens.

Next we tag the PR's with the fixes or enhancements labels. If the PR does not fufil the requirements, do not add a label.
Next we tag the PR's with the fixes or enhancements labels. If the PR does not fulfil the requirements, do not add a label.

Run the changelog generator again with the future version according to semver.

Expand Down
2 changes: 1 addition & 1 deletion drone/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ func (c *client) Promote(namespace, name string, build int, target string, param
return out, err
}

// Roolback reverts the target environment to an previous build.
// Rollback reverts the target environment to an previous build.
func (c *client) Rollback(namespace, name string, build int, target string, params map[string]string) (*Build, error) {
out := new(Build)
val := mapValues(params)
Expand Down
4 changes: 2 additions & 2 deletions drone/interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (

// TODO(bradrydzewski) add repo + latest build endpoint
// TODO(bradrydzewski) add queue endpoint
// TDOO(bradrydzewski) add stats endpoint
// TODO(bradrydzewski) add stats endpoint
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notable

// TODO(bradrydzewski) add version endpoint

// Client is used to communicate with a Drone server.
Expand Down Expand Up @@ -85,7 +85,7 @@ type Client interface {
// RepoDisable disables a repository.
RepoDisable(namespace, name string) error

// RepoDelete permanetnly deletes a repository.
// RepoDelete permanently deletes a repository.
RepoDelete(namespace, name string) error

// Build returns a repository build by number.
Expand Down
2 changes: 1 addition & 1 deletion plugin/config/handler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func TestHandler(t *testing.T) {

want := &drone.Config{
Kind: "drone.v1.yaml",
Data: "pipeilne: []",
Data: "pipeline: []",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notable

}
plugin := &mockPlugin{
res: want,
Expand Down
2 changes: 1 addition & 1 deletion plugin/internal/aesgcm/aesgcm.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func Encrypt(plaintext []byte, key *[32]byte) (ciphertext []byte, err error) {
return gcm.Seal(nonce, nonce, plaintext, nil), nil
}

// Decrypt decrypts the raw, unencoded cihpertext with the provided key.
// Decrypt decrypts the raw, unencoded ciphertext with the provided key.
func Decrypt(ciphertext []byte, key *[32]byte) (plaintext []byte, err error) {
block, err := aes.NewCipher(key[:])
if err != nil {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hanging comment about the file that's renamed below here...

The package internally calls itself validator...

Expand Down
File renamed without changes.