Merge pull request #30 from uWaterloo/fopen-append

Use append-only mode in fopen()
drupal-composer · Mar 25, 2020 · 9f13a21 · 9f13a21
2 parents e211938 + 2fb3919
commit 9f13a21
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Writer/Drupal.php b/src/Writer/Drupal.php
@@ -40,7 +40,7 @@ public function rewrite($version, $timestamp, $core = null, $project = null)
         foreach ($this->paths as $info_file) {
             // Don't write to files that already contain version information.
             if (!$this->hasVersionInfo($info_file)) {
-                $file = fopen($info_file, 'a+');
+                $file = fopen($info_file, 'a');
                 $coreToWrite = $this->hasCoreVersionRequirement($info_file) ? null : $core;
                 fwrite($file, $this->formatInfo($version, $timestamp, $coreToWrite, $project));
                 fclose($file);

diff --git a/tests/DrupalInfoTest.php b/tests/DrupalInfoTest.php
@@ -221,7 +221,7 @@ public function testRollbackRewrite()
 timestamp: 1234
 EOL;
         foreach ($files as $file) {
-            $handle = fopen($file, 'a+');
+            $handle = fopen($file, 'a');
             fwrite($handle, $info_pattern);
             fclose($handle);
             $this->assertContains($info_pattern, file_get_contents($file));