Merge pull request #4 from drupal-composer/03-version-info

Skip modules that already have version info.

src/Writer/Drupal.php

@@ -7,6 +7,11 @@
  */
 class Drupal implements WriterInterface
 {
+    /**
+     * Pattern to indicate a file already has version info.
+     */
+    const VERSION_EXISTS_PATTERN = '#version:.*[\d+].*#';
+
     /**
      * File paths to rewrite.
      *
@@ -28,9 +33,12 @@ public function set(array $paths)
     public function rewrite($version, $timestamp)
     {
         foreach ($this->paths as $info_file) {
-            $file = fopen($info_file, 'a+');
-            fwrite($file, $this->formatInfo($version, $timestamp));
-            fclose($file);
+            // Don't write to files that already contain version information.
+            if (!$this->hasVersionInfo($info_file)) {
+                $file = fopen($info_file, 'a+');
+                fwrite($file, $this->formatInfo($version, $timestamp));
+                fclose($file);
+            }
         }
     }
 
@@ -61,4 +69,19 @@ protected function formatInfo($version, $timestamp)
 EOL;
         return $info;
     }
+
+    /**
+     * Determine if a given file already contains version info.
+     *
+     * @param string $file_path
+     *   Path to the info file.
+     *
+     * @return bool
+     *   Returns true if file already has version info.
+     */
+    protected function hasVersionInfo($file_path)
+    {
+        $contents = file_get_contents($file_path);
+        return preg_match(static::VERSION_EXISTS_PATTERN, $contents);
+    }
 }

src/Writer/Drupal7.php

@@ -7,6 +7,10 @@
  */
 class Drupal7 extends Drupal
 {
+    /**
+     * {@inheritdoc}
+     */
+    const VERSION_EXISTS_PATTERN = '#version=.*[\d+].*#';
 
     /**
      * Format version and timestamp into INI format.

tests/DrupalInfoTest.php

@@ -119,6 +119,11 @@ public function testInstallOperationWriteInfoFiles()
             $this->assertFileExists($file);
             $this->assertContains($info, file_get_contents($file));
         }
+
+        // Verify that module with existing version information is not updated.
+        $file = $this->getDirectory() . '/module_with_version/module_with_version.info.yml';
+        $this->assertFileExists($file);
+        $this->assertNotContains($info, file_get_contents($file));
     }
 
     /**

tests/InfoFileTrait.php

@@ -31,6 +31,9 @@ public function generateDirectories()
                         ],
                     ],
                 ],
+                'module_with_version' => [
+                    'module_with_version.info.yml' => "name: module with version\nversion:8.x-1.0-alpha4",
+                ],
             ],
             // Drupal 7.
             'drupal7' => [
@@ -48,6 +51,9 @@ public function generateDirectories()
                         ],
                     ],
                 ],
+                'module_with_version' => [
+                    'module_with_version.info' => "name = module with version\nversion = 8.x-1.0-alpha4",
+                ],
             ],
 
         ]);