Skip to content
This repository has been archived by the owner on Jan 5, 2018. It is now read-only.

$instance_uuid not passed to RegisterJSCallbacks::__construct() in built in Displays. #107

Open
wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from

Conversation

mortenson
Copy link
Member

Copied from https://www.drupal.org/node/2600706:

In both the Modal and IFrame Display plugins, the REGISTER_JS_CALLBACKS event is dispatched and RegisterJSCallbacks objects are created without passing the required $instance_uuid argument. I would submit a patch but I'm not sure where we can get an instance UUID for the Entity Browser (I believe it's abstracted from the Display Plugin). The relevant calls are in Modal::displayEntityBrowser() and IFrame::displayEntityBrowser().

…sterJSCallbacks::__construct() in built in Displays.
@mortenson mortenson mentioned this pull request Oct 28, 2015
@@ -188,6 +188,7 @@ public function getDisplay() {
*/
protected function displayPluginCollection() {
if (!$this->displayCollection) {
$this->display_configuration['instance_uuid'] = $this->uuid();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to avoid having any state information for entity browser instances in EntityBrowser class.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants