This repository has been archived by the owner on Jan 5, 2018. It is now read-only.
Fix constraint validation, match regex against url-string not value #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,13 +20,14 @@ class VideoProviderMatchConstraintValidator extends ConstraintValidator { | |||
| */ | |||
| public function validate($value, Constraint $constraint) { | |||
| $regexes = $constraint->getRegularExpressionsOption(); | |||
| if (empty($value)) { | |||
| $url = $value->getUrl()->toString(); | |||
There was a problem hiding this comment.
Link fields are not the only field types that are supported in media_entity_embeddable_video. This code assumes it is.
|
This should have been resolved with 2199a19. Feel free to re-open if not. Thank you for your contribution. |
|
It is fixed in our project with the most current dev version. Feel free to close it @slashrsm. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.