Handle metaclasses in subclass query

dseomn · Nov 14, 2023 · a672c4d · a672c4d
1 parent b20b430
commit a672c4d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/rock_paper_sand/wikidata.py b/rock_paper_sand/wikidata.py
@@ -200,10 +200,18 @@ def transitive_subclasses(
     ) -> Set[wikidata_value.ItemRef]:
         """Returns transitive subclasses of the given class."""
         if class_ref not in self._transitive_subclasses:
-            subclass_of = wikidata_value.P_SUBCLASS_OF.id
+            subclass_predicate = "|".join(
+                (
+                    f"wdt:{wikidata_value.P_SUBCLASS_OF.id}",
+                    (
+                        f"(wdt:{wikidata_value.P_INSTANCE_OF.id}/"
+                        f"wdt:{wikidata_value.P_IS_METACLASS_FOR.id})"
+                    ),
+                )
+            )
             results = self.sparql(
                 "SELECT REDUCED ?class WHERE { "
-                f"?class wdt:{subclass_of}* wd:{class_ref.id}. "
+                f"?class ({subclass_predicate})* wd:{class_ref.id}. "
                 "?class wikibase:sitelinks []. "
                 "}"
             )

diff --git a/rock_paper_sand/wikidata_value.py b/rock_paper_sand/wikidata_value.py
@@ -190,6 +190,7 @@ def human_readable_url_prefix(cls) -> str:
 P_HAS_PARTS = _p("https://www.wikidata.org/wiki/Property:P527")
 P_HAS_SPIN_OFF = _p("https://www.wikidata.org/wiki/Property:P2512")
 P_INSTANCE_OF = _p("https://www.wikidata.org/wiki/Property:P31")
+P_IS_METACLASS_FOR = _p("https://www.wikidata.org/wiki/Property:P8225")
 P_MANIFESTATION_OF = _p("https://www.wikidata.org/wiki/Property:P1557")
 P_MEDIA_FRANCHISE = _p("https://www.wikidata.org/wiki/Property:P8345")
 P_MODIFIED_VERSION_OF = _p("https://www.wikidata.org/wiki/Property:P5059")