Add https:// to front of domain argument if it's not a URL #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "domain" argument to the 2FAS API isn't actually expecting a domain, it's expecting a URL (see twofas/2fas-server#6). Arguably it would be better to rename the "--domain" argument in this script to "--url" for clarity, but absent that, at the very least we should check if the user specifies a domain instead of a URL—since that's what the parameter is called, it's an easy mistake to make!—and if so, then add "https://" to the beginning of it so that we're passing the 2FAS server something it expects. Fixes dspitzer#1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "domain" argument to the 2FAS API isn't actually expecting a domain, it's expecting a URL (see
twofas/2fas-server#6).
Arguably it would be better to rename the "--domain" argument in this script to "--url" for clarity, but absent that, at the very least we should check if the user specifies a domain instead of a URL—since that's what the parameter is called, it's an easy mistake to make!—and if so, then add "https://" to the beginning of it so that we're passing the 2FAS server something it expects.
Fixes #1.