fix: prevent Radix Dialog and Vaul Drawer dismissal when closing a toast #1725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1654 by ensuring that clicking inside a Sonner Toast does not trigger the closure of Radix Dialog and Vaul Drawer components.
Root Cause
When using the Dub app, clicking within a toast notification was being interpreted as an "outside click" for Radix Dialog and Vaul Drawer components. Since all of these elements are rendered in the same HTML portal layer, the default behavior is to close dialogs and drawers on outside clicks.
Fix
To prevent dialogs and drawers from closing due to clicks inside a toast notification, this update adds a check to detect clicks within elements marked with
data-sonner-toast
. When a click is detected in such an element, the default dismiss action is prevented, allowing dialogs and drawers to remain open.How to test?