Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DuckPGQ for v1.1.1 #126

Closed
wants to merge 2 commits into from
Closed

Conversation

Dtenwolde
Copy link
Contributor

No description provided.

@Dtenwolde
Copy link
Contributor Author

I'm not exactly sure where it goes wrong, but it currently builds against duckdb/duckdb, while the extension is supposed to build against cwida/duckdb-pgq. Is there something I missed setting up? My own CI passed https://github.com/cwida/duckpgq-extension/actions/runs/11040549104. Please let me know :)

@carlopi
Copy link
Collaborator

carlopi commented Sep 27, 2024

I will have a look later, CI setup changed in duckdb/extension-ci-tools#79, unsure of that or elsewhere something is now off.

@carlopi
Copy link
Collaborator

carlopi commented Oct 2, 2024

@Dtenwolde: I think the problem is here: https://github.com/cwida/duckpgq-extension/blob/f2204a248ff6524f71e262d4c36b71c57444caee/src/include/duckpgq/core/utils/compressed_sparse_row.hpp#L18, where it should likely work with "" instead of <>.

Your build system is also wired differently, using duckdbpgq instead of duckdb as base folder, so problems are not visible there.

@Dtenwolde Dtenwolde closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants