Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadable extensions #372

Closed
wants to merge 4 commits into from
Closed

Conversation

0xcaff
Copy link

@0xcaff 0xcaff commented Aug 14, 2024

integrating the changes from duckdb/duckdb#12682

current issues (needs discussion):

  • there are a handful of functions missing from the extensions header (duckdb_row_count, duckdb_arrow_row_count, duckdb_query_arrow_array, duckdb_query_arrow_schema, duckdb_arrow_column_count, duckdb_value_varchar, duckdb_execute_prepared_arrow, duckdb_arrow_rows_changed, duckdb_destroy_arrow). i'm not sure what to do about them. it seems like a bunch of them are part of arrow (idk whether it makes sense to expose that through the extensions api) and the others i'm not sure about.
  • how does versioning work in this new extensions api
  • idk how the macro works for DUCKDB_EXTENSION_ENTRYPOINT
  • do we want one big static object instead of a million small atomic pointers for this

todo:

  • figure out bundling for extension headers

related:

starting with getting this working only for buildtime_bindgen first

todo:
* not buildtime_bindgen
* bundled version
ok i'm actually pretty happy with this, seems like its close to building at this point
@0xcaff
Copy link
Author

0xcaff commented Sep 11, 2024

this is a dupe of sam's work, closing in favor of that #370

@0xcaff 0xcaff closed this Sep 11, 2024
@0xcaff 0xcaff deleted the martin/loadable_extensions branch September 11, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant