Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix UI tests broken by tabs suggestions #3402

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix UI tests broken by tabs suggestions #3402

wants to merge 2 commits into from

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Sep 26, 2024

Task/Issue URL: https://app.asana.com/0/392891325557410/1208408323212083/f
Tech Design URL:
CC:

Description:
Adding tabs to suggestions broke a test.
Maestro is behaving strangely in another test.

Steps to test this PR:

  1. Check the state of this end to end run: https://github.com/duckduckgo/iOS/actions/runs/11056977820
  • release tests should all pass, the other tests may pass if re-run but currently appear to be flakey
  1. Run release/ tests locally

loremattei
loremattei approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are still failing on CI, but this PR is contributing to improve the current situation, so I'd say it's safe to merge and take care of flakiness of the password tests in a subsequent one.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loremattei loremattei loremattei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brindy @loremattei