Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump log4j.version from 2.23.1 to 2.24.0 #5441

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 9, 2024

Bumps log4j.version from 2.23.1 to 2.24.0.
Updates org.apache.logging.log4j:log4j-api from 2.23.1 to 2.24.0

Updates org.apache.logging.log4j:log4j-core from 2.23.1 to 2.24.0

Updates org.apache.logging.log4j:log4j-jcl from 2.23.1 to 2.24.0

Updates org.apache.logging.log4j:log4j-jul from 2.23.1 to 2.24.0

Updates org.apache.logging.log4j:log4j-slf4j2-impl from 2.23.1 to 2.24.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner September 9, 2024 03:23
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 9, 2024
@dizzzz

This comment has been minimized.

@dizzzz
Copy link
Member

dizzzz commented Sep 10, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 10, 2024

Looks like this PR is already up-to-date with develop! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@dizzzz
Copy link
Member

dizzzz commented Sep 10, 2024

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/maven/log4j.version-2.24.0 branch from f3e16a6 to c284b9d Compare September 10, 2024 17:01
Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to re-enable log4j2/jmx support

@reinhapa

See https://logging.apache.org/log4j/2.x/release-notes.html

@reinhapa
Copy link
Member

I think we need to re-enable log4j2/jmx support

@reinhapa

See https://logging.apache.org/log4j/2.x/release-notes.html

I guess... I just do not know where that should be done best...

Bumps `log4j.version` from 2.23.1 to 2.24.0.

Updates `org.apache.logging.log4j:log4j-api` from 2.23.1 to 2.24.0

Updates `org.apache.logging.log4j:log4j-core` from 2.23.1 to 2.24.0

Updates `org.apache.logging.log4j:log4j-jcl` from 2.23.1 to 2.24.0

Updates `org.apache.logging.log4j:log4j-jul` from 2.23.1 to 2.24.0

Updates `org.apache.logging.log4j:log4j-slf4j2-impl` from 2.23.1 to 2.24.0

---
updated-dependencies:
- dependency-name: org.apache.logging.log4j:log4j-api
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.logging.log4j:log4j-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.logging.log4j:log4j-jcl
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.logging.log4j:log4j-jul
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.logging.log4j:log4j-slf4j2-impl
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/log4j.version-2.24.0 branch from c284b9d to c2868c5 Compare September 13, 2024 08:37
@dizzzz
Copy link
Member

dizzzz commented Sep 13, 2024

In the code (both server as test) we already set System properties. I guess we have to set it in a @before method for the failing class, and find a good location where we can set this system wide. Main? Launcher? Command line ?

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 30, 2024

Superseded by #5455.

@dependabot dependabot bot closed this Sep 30, 2024
@dependabot dependabot bot deleted the dependabot/maven/log4j.version-2.24.0 branch September 30, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants