Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update AppConfig file directories in README.md #183 #241

Merged

Conversation

farhin23
Copy link
Contributor

What this PR changes/adds

Updates the app.config.json file directories in README.md

Why it does that

The app.config.json files exist in the ./system-tests/resources/appconfig/ directory and its creation is not related to MVD deployment.
The location of these config files, mentioned in the README was not relative to root directory and thus created ambiguity. These files are stored under the system-tests/resource folder and not in the resource folder that is in root directory.

The README.md file has been updated with the correct locations of app.config.json files.

Linked Issue(s)

Closes #183

@juliapampus juliapampus changed the title fix: Update AppConfig file directories in README.md #183 docs: update AppConfig file directories in README.md #183 Mar 15, 2024
@juliapampus juliapampus self-requested a review March 15, 2024 12:46
@mspiekermann mspiekermann self-requested a review April 9, 2024 06:50
@ndr-brt ndr-brt merged commit b6147d0 into eclipse-edc:main Apr 9, 2024
6 checks passed
@juliapampus juliapampus deleted the fix/appconfig-files-not-created-183 branch April 9, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppConfig files are not created
3 participants