Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: consistent case for X-Api-Key in postman collection #285

Merged
merged 1 commit into from
Jul 11, 2024
Merged

chore: consistent case for X-Api-Key in postman collection #285

merged 1 commit into from
Jul 11, 2024

Conversation

man8pr
Copy link
Contributor

@man8pr man8pr commented Jul 11, 2024

  • when importing with HTTP client plugin in IntelliJ, only one key is generated

@man8pr
chore: consistent case for X-Api-Key in postman collection
07b1de2 
- when importing with HTTP client plugin in IntelliJ, only one key is generated
@man8pr man8pr added the documentation Improvements or additions to documentation label Jul 11, 2024
paullatzelsperger
paullatzelsperger reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm assuming this is mostly a cosmetic issue? headers should not be case-sensitive

@man8pr
Copy link
Contributor Author

man8pr commented Jul 11, 2024

i'm assuming this is mostly a cosmetic issue? headers should not be case-sensitive

When exporting with HTTP Client plugin for IntelliJ, different cases generate different parameters, so making it consistent will be beneficial when using HTTP Client with IntelliJ

@paullatzelsperger paullatzelsperger merged commit e53b2d8 into eclipse-edc:main Jul 11, 2024
8 checks passed
@paullatzelsperger paullatzelsperger mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullatzelsperger paullatzelsperger paullatzelsperger approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@man8pr @paullatzelsperger