just: ensure peerpod vms are cleaned up on undeploy #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freax13
reviewed
Nov 4, 2024
davidweisse
force-pushed
the
dav/just-undeploy-peerpod
branch
from
1641635
to
e4ed877
Compare
Freax13
approved these changes
Nov 4, 2024
davidweisse
force-pushed
the
dav/just-undeploy-peerpod
branch
from
e4ed877
to
aeb4160
Compare
Freax13
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the
cloud-api-adaptorcleanly deletes the created VMs by waiting until the deletion of all other resources has been completed before deleting the node installer and namespace.