Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wip/sal/helm #17

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Wip/sal/helm #17

wants to merge 8 commits into from

Conversation

sofusalbertsen
Copy link
Contributor

No description provided.

@zanderhavgaard
Copy link
Contributor

Looks really good :D

2 small things:

  • should the hardcoded version in the chart.yaml and values.yaml be 5.0.0 ?
  • please add a section in the readme on how to use the helm chart.

Otherwise really awesome stuff 🤘

zanderhavgaard
zanderhavgaard suggested changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@zanderhavgaard zanderhavgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a section in the readme on how to use the helm chart.

@sofusalbertsen
Copy link
Contributor Author

Great additions, done 👍

@sofusalbertsen
Copy link
Contributor Author

@zanderhavgaard when you have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderhavgaard zanderhavgaard Awaiting requested review from zanderhavgaard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sofusalbertsen @zanderhavgaard