Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename class name to HourRotator #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaidiren
Copy link

this file is Hour Rotator not day Rotator

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

this file is Hour Rotator not day Rotator
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #29 (1899199) into master (46b6876) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files          14       14           
  Lines         210      210           
=======================================
  Hits          202      202           
  Misses          8        8           
Impacted Files Coverage Δ
app/lib/hour_rotator.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46b6876...230e099. Read the comment docs.

@elvinn
Copy link

elvinn commented Mar 2, 2021

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants