Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize README in English #99

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

hongzzz
Copy link
Contributor

@hongzzz hongzzz commented Jul 3, 2024

请原谅我改一些明显的语法错误😀

Summary by CodeRabbit

  • Documentation
    • Improved clarity and correctness in security-related instructions and configurations.
    • Refined explanations for disabling security measures and configuring security plugins.
    • Corrected grammar and terminology for better understanding.
    • Enhanced documentation consistency.

Copy link
Contributor

coderabbitai bot commented Jul 3, 2024

Walkthrough

The changes in README.md focus on enhancing clarity and correctness in the security-related instructions and configurations. Corrections include refining instructions for disabling security precautions, improving configuration explanations, correcting grammar, and ensuring consistency throughout the documentation.

Changes

File Change Summary
README.md Improved clarity and grammatical correctness in security-related instructions and configurations, including disabling security features, configuring options dynamically, and addressing specific scenarios.

Poem

🐰 In the world of code so bright,
Words polished for the reader's sight.
Security made clear and neat,
Instructions now a flawless feat.
Through careful pen, clarity shines,
Guarding code like strong, wise pines. 🌲

Tip

AI model upgrade

gpt-4o model for reviews and chat is now live

OpenAI claims that this model is better at understanding and generating code than the previous models. Please join our Discord Community to provide any feedback or to report any issues.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Jul 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 3a0645c

egg-security

npm i https://pkg.pr.new/eggjs/egg-security@99


templates

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ab21532 and 3a0645c.

Files selected for processing (1)
  • README.md (7 hunks)
Additional context used
LanguageTool
README.md

[style] ~504-~504: ‘by mistake’ might be wordy. Consider a shorter alternative.
Context: ... E.g.: take text/plain as text/html by mistake and render it, especially when there's ...

(EN_WORDINESS_PREMIUM_BY_MISTAKE)

Additional comments not posted (12)
README.md (12)

42-42: Improvement in clarity and grammar.

The sentence has been improved for clarity and grammatical correctness:

  • Before: If you want to disable some security precautions, set enable porperty to 'false' directly.
  • After: To disable some security precautions, set enable property to 'false' directly.

This change enhances readability and correctness.


99-99: Correction in grammar and punctuation.

The sentence has been corrected for grammar and punctuation:

  • Before: Then we can configure ctx.securityOptions[name] opts in the custom middleware or controller,then the current request configuration will overrides the default configuration (new configuration will be merged and override the default project configuration, but only take effect in the current request)
  • After: Then we can configure ctx.securityOptions[name] opts in the custom middleware or controller, then the current request configuration will override the default configuration (new configuration will be merged and override the default project configuration, but only take effect in the current request)

This change improves readability and correctness.


115-115: Correction in grammar and clarity.

The sentence has been corrected for grammar and clarity:

  • Before: Not all security plugins support dynamic configuration, only following plugins list support
  • After: Not all security plugins support dynamic configuration, only the following plugins list support

This change improves readability and correctness.


394-394: Correction in grammar and clarity.

The sentence has been corrected for grammar and clarity:

  • Before: So please check the applicable scenarios for shtml, it usually used for richtext submmited by user.
  • After: So please check the applicable scenarios for shtml, it is usually used for rich-text submitted by user.

This change improves readability and correctness.


396-396: Correction in grammar and clarity.

The sentence has been corrected for grammar and clarity:

  • Before: A usage error will limit functions, also affect the performance of the server.
  • After: A usage error will limit functions, and also affect the performance of the server.

This change improves readability and correctness.


483-483: Correction in grammar and clarity.

The sentence has been corrected for grammar and clarity:

  • Before: Refer to [lusca](https://github.com/krakenjs/lusca), appriciate for their works.
  • After: Refer to [lusca](https://github.com/krakenjs/lusca), appreciate their work.

This change improves readability and correctness.


494-494: Correction in grammar and clarity.

The sentence has been corrected for grammar and clarity:

  • Before: Default disabled. If you need to enable it, please contact your security engineers and determine the opening strategy
  • After: Default disabled. If you need to enable it, please contact your security engineers and determine the opening strategy.

This change improves readability and correctness.


500-500: Correction in grammar and clarity.

The sentence has been corrected for grammar and clarity:

  • Before: Default enabled, disable IE download dialog automatically open download file and will cause XSS
  • After: Default enabled, disable IE download dialog automatically opens download file and will cause XSS

This change improves readability and correctness.


504-504: Correction in grammar and clarity.

The sentence has been corrected for grammar and clarity:

  • Before: Disable IE8's auto MIME sniffing. E.g.: take text/plainastext/html by mistake and render it, especially when there's something untrusted in the local service.
  • After: Disable IE8's auto MIME sniffing. E.g.: take text/plainastext/html incorrectly and render it, especially when there's something untrusted in the local service.

This change improves readability and correctness.

Tools
LanguageTool

[style] ~504-~504: ‘by mistake’ might be wordy. Consider a shorter alternative.
Context: ... E.g.: take text/plain as text/html by mistake and render it, especially when there's ...

(EN_WORDINESS_PREMIUM_BY_MISTAKE)


508-508: Correction in grammar and clarity.

The sentence has been corrected for grammar and clarity:

  • Before: Defaulting to "SAMEORIGIN", only allow iframe embed by same origin.
  • After: Defaulting to "SAMEORIGIN", only allows iframe to embed by the same origin.

This change improves readability and correctness.


514-514: Correction in grammar and clarity.

The sentence has been corrected for grammar and clarity:

  • Before: - disable Defaulting to false,same as 1; mode=block.
  • After: - disable Defaulting to false, the same as 1; mode=block.

This change improves readability and correctness.


524-525: Correction in grammar and clarity.

The sentences have been corrected for grammar and clarity:

  • Before: - ipBlackList(Array) - specific which ip are illegal when request with safeCurl.

  • After: - ipBlackList(Array) - specific which IP addresses are illegal when requested with safeCurl.

  • Before: - ipExceptionList(Array) - specific which ip are legal within ipBlackList.

  • After: - ipExceptionList(Array) - specific which IP addresses are legal within ipBlackList.

These changes improve readability and correctness.

@fengmk2 fengmk2 merged commit b4d8baa into eggjs:master Jul 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants