-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement remote cluster CCS telemetry #112478
Conversation
Documentation preview: |
506107a
to
f1bb066
Compare
f1bb066
to
8b86ac4
Compare
0386b6c
to
a07206e
Compare
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the right sort of shape to me now. I left a few more comments.
.../src/main/java/org/elasticsearch/action/admin/cluster/stats/TransportClusterStatsAction.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/action/admin/cluster/stats/TransportClusterStatsAction.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/action/admin/cluster/stats/TransportClusterStatsAction.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/action/admin/cluster/stats/TransportClusterStatsAction.java
Outdated
Show resolved
Hide resolved
...ain/java/org/elasticsearch/action/admin/cluster/stats/TransportRemoteClusterStatsAction.java
Show resolved
Hide resolved
...er/src/main/java/org/elasticsearch/action/admin/cluster/stats/RemoteClusterStatsRequest.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/elasticsearch/action/admin/cluster/stats/RemoteClusterStatsRequest.java
Show resolved
Hide resolved
...er/src/main/java/org/elasticsearch/action/admin/cluster/stats/RemoteClusterStatsRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/admin/cluster/stats/ClusterStatsResponse.java
Outdated
Show resolved
Hide resolved
Looks like ActionListener.run should take care of this part. This reverts commit 40090bc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work here!
💔 Backport failedThe backport operation could not be completed due to the following error:
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* Add remote cluster stats to _cluster/stats * Implement remote cluster stats polling * Add docs for the include_remotes part (cherry picked from commit b26d81c)
Implements remote stats for
_cluster/stats
with new parameterinclude_remotes
.