Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Port connector docs #112953

Merged
merged 54 commits into from
Sep 30, 2024
Merged

[DOCS] Port connector docs #112953

merged 54 commits into from
Sep 30, 2024
+18,457 −77

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Sep 16, 2024 •
edited
Loading

📸URL preview

Summary

Ports connector docs from Enterprise Search guide to Elasticsearch guide.

@leemthompo leemthompo added the >docs General docs changes label Sep 16, 2024
@leemthompo leemthompo self-assigned this Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@leemthompo leemthompo changed the title [TEST][DOCS] Move connector docs [TEST][DOCS] Port connector docs Sep 16, 2024
@danajuratoni
Copy link

LGTM
One question: I liked the initial proposal use a top level like "Ingest content" where we could bring connectors and crawler. Is that something you still see as a possibility in the near future (8.17-8.18)?

@leemthompo
Copy link
Contributor Author

One question: I liked the initial proposal use a top level like "Ingest content" where we could bring connectors and crawler. Is that something you still see as a possibility in the near future (8.17-8.18)?

We might need the next docs system to be able to nest these connector references that deeply. If we go one more level, we lose all the "On this page" subheadings in the connectors docs in the current asciidoc system.

@leemthompo leemthompo changed the title [TEST][DOCS] Port connector docs [DOCS] Port connector docs Sep 27, 2024
@leemthompo leemthompo marked this pull request as ready for review September 27, 2024 09:42
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Sep 27, 2024
@danajuratoni
Copy link

Got it!
That's a bummer

seanstory
seanstory approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@seanstory seanstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubberstamp

@danajuratoni
Update _connectors-overview-table.asciidoc
a2b2387 
Reverting the Advanced Sync rules column for SP Server, my mistake.
@leemthompo leemthompo merged commit 6e400c1 into elastic:main Sep 30, 2024
5 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 112953

@leemthompo leemthompo mentioned this pull request Sep 30, 2024
Merged
@leemthompo
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Questions ?

Please refer to the Backport tool documentation

leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Sep 30, 2024
@leemthompo
[DOCS] Port connector docs from Enterprise Search guide (elastic#112953)
3cd9b5a 
(cherry picked from commit 6e400c1)
elasticsearchmachine pushed a commit that referenced this pull request Sep 30, 2024
@leemthompo
[DOCS] Port connector docs from Enterprise Search guide (#112953) (#1…
a7dfc80 
…13771)

(cherry picked from commit 6e400c1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanstory seanstory seanstory approved these changes

Assignees

@leemthompo leemthompo

Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready backport pending >docs General docs changes Team:Docs Meta label for docs team v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leemthompo @danajuratoni @elasticsearchmachine @seanstory