Deprecate dutch_kp and lovins stemmer as they are removed in Lucene 10 #113143
Conversation
benwtrent
added
:Search Relevance/Analysis
|
Documentation preview: |
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Hi @benwtrent, I've created a changelog YAML for you. Note that since this PR is labelled |
docs/changelog/113143.yaml
Outdated
| title: Deprecate dutch_kp and lovins stemmer as they are removed in Lucene 10 | ||
| area: Analysis | ||
| details: kp, dutch_kp, dutchKp and lovins stemmers are deprecated and will be removed. | ||
| impact: These stemmers will be removed and will no longer supported. |
There was a problem hiding this comment.
nit: "no longer be supported"
benwtrent
added
the
auto-backport-and-merge
|
@elasticmachine update branch |
|
@elasticsearchmachine test this please |
benwtrent
added
the
auto-merge
elastic#113143) Lucene 10 has upgraded its Snowball stemming support, as part of those upgrades, two no longer supported stemmers were removed, `KpStemmer` and `LovinsStemmer`. These are `dutch_kp` and `lovins`, respectively. We will deprecate in 8.16 and will remove support for these in a future version.
💚 Backport successful
|
|
heya the new tests kind of forced me make these stemmers no-op otherwise we'd throw UOE. I made that quick change in 79d3d6a . I also moved the deprecation warnings to be closer with the creation of the no-op token filter. Not sure whether we want to add tests for this etc. |
|
@javanna I think that is ok. This PR was focused on getting deprecation warning set up for 8x where behavior is the same just deprecated. I realize this code will have to change for Lucene 10. |
Lucene 10 has upgraded its Snowball stemming support, as part of those upgrades, two no longer supported stemmers were removed,
KpStemmerandLovinsStemmer. These aredutch_kpandlovins, respectively.We will deprecate in 8.16 and will remove support for these in a future version.