Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate legacy params from range query #113286

Merged
merged 15 commits into from
Sep 25, 2024
Merged

Deprecate legacy params from range query #113286

merged 15 commits into from
Sep 25, 2024

Conversation

mayya-sharipova
Copy link
Contributor

@mayya-sharipova mayya-sharipova commented Sep 20, 2024 •
edited
Loading

Deprecate to, from, include_lower, include_upper range query params.
These params have been removed from our documentation in v. 0.90.4 (d6ecdec), but did not got through deprecation cycle.

These params to be removed in v9.0.

Related to #81276

Relates #48538

@mayya-sharipova
Deprecate legacy params from range query
f2601cc 
Deprecate to, from, include_lower, include_upper range query params.
These params have been removed from our documentation in v. 0.90.4 (d6ecdec),
but did not got through deprecation cycle.

These params to be removed in v9.0.

Related to elastic#81276

Closes elastic#48538
@mayya-sharipova mayya-sharipova added :Search/Search Search-related issues that do not fall into other categories >deprecation labels Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team v9.0.0 labels Sep 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine
Copy link
Collaborator

Hi @mayya-sharipova, I've created a changelog YAML for you. Note that since this PR is labelled >deprecation, you need to update the changelog YAML to fill out the extended information sections.

@elasticsearchmachine
Copy link
Collaborator

Hi @mayya-sharipova, I've updated the changelog YAML for you. Note that since this PR is labelled >deprecation, you need to update the changelog YAML to fill out the extended information sections.

benwtrent
benwtrent reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, the change log needs updating.

docs/changelog/113286.yaml Outdated Show resolved Hide resolved
benwtrent
benwtrent approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. LOL it's been an undocumented/deprecated feature since before ES v1.

Now, time to see if CI will ever be ✅ :)

@mayya-sharipova mayya-sharipova requested a review from a team as a code owner September 23, 2024 15:54
@mayya-sharipova mayya-sharipova removed the request for review from a team September 23, 2024 15:54
@mayya-sharipova mayya-sharipova added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label Sep 23, 2024
@mayya-sharipova mayya-sharipova added auto-backport Automatically create backport pull requests when merged and removed auto-backport-and-merge Automatically create backport pull requests and merge when ready labels Sep 23, 2024
@mayya-sharipova
Copy link
Contributor Author

@elasticsearchmachine run elasticsearch-ci/bwc-snapshots

@mayya-sharipova
Copy link
Contributor Author

@elasticsearchmachine run elasticsearch-ci/8.16.0 / bwc-snapshots

@mayya-sharipova
Copy link
Contributor Author

@elasticsearchmachine "run elasticsearch-ci/8.16.0 / bwc-snapshots"

1 similar comment
@mayya-sharipova
Copy link
Contributor Author

@elasticsearchmachine "run elasticsearch-ci/8.16.0 / bwc-snapshots"

@mayya-sharipova
Copy link
Contributor Author

@elasticsearchmachine run elasticsearch-ci/bwc-snapshots

@mayya-sharipova mayya-sharipova merged commit c18c531 into elastic:main Sep 25, 2024
15 checks passed
@mayya-sharipova mayya-sharipova deleted the deprecate_range_params branch September 25, 2024 18:48
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 113286

@pquentin pquentin mentioned this pull request Sep 26, 2024
Merged
mayya-sharipova added a commit to mayya-sharipova/elasticsearch that referenced this pull request Sep 26, 2024
@mayya-sharipova
Deprecate legacy params from range query (elastic#113286)
312c31e 
Deprecate to, from, include_lower, include_upper range query params.
These params have been removed from our documentation in v. 0.90.4 (d6ecdec),
but did not got through deprecation cycle.

These params to be removed in v9.0.

Related to elastic#81276

Closes elastic#48538
elasticsearchmachine pushed a commit that referenced this pull request Sep 26, 2024
@mayya-sharipova
Deprecate legacy params from range query (#113286) (#113610)
7719f17 
Deprecate to, from, include_lower, include_upper range query params.
These params have been removed from our documentation in v. 0.90.4 (d6ecdec),
but did not got through deprecation cycle.

These params to be removed in v9.0.

Related to #81276

Closes #48538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwtrent benwtrent benwtrent approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged backport pending >deprecation :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayya-sharipova @elasticsearchmachine @benwtrent